Skip to content

Commit 7acd136

Browse files
committed
Including reviewer's comments.
1 parent 978ca23 commit 7acd136

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

src/main/java/edu/ie3/simona/api/data/connection/ExtEmDataConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public List<UUID> getControlledEms() {
4545
public void sendSetPoints(
4646
long tick, Map<UUID, EmSetPoint> setPoints, Optional<Long> maybeNextTick, Logger log) {
4747
if (setPoints.isEmpty()) {
48-
log.warn("No em set points found! Sending no em data to SIMONA for tick {}.", tick);
48+
log.debug("No em set points found! Sending no em data to SIMONA for tick {}.", tick);
4949
} else {
5050
log.debug("Provided SIMONA with em set points.");
5151
sendExtMsg(new ProvideEmSetPointData(tick, setPoints, maybeNextTick));

src/main/java/edu/ie3/simona/api/data/connection/ExtPrimaryDataConnection.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,9 @@ public Optional<Class<Value>> getValueClass(UUID uuid) {
4949
public void sendPrimaryData(
5050
long tick, Map<UUID, Value> primaryData, Optional<Long> maybeNextTick, Logger log) {
5151
if (primaryData.isEmpty()) {
52-
log.warn("No primary data found! Sending no primary data to SIMONA for tick {}.", tick);
52+
log.debug("No primary data found! Sending no primary data to SIMONA for tick {}.", tick);
5353
} else {
5454
log.debug("Provided SIMONA with primary data. Data: {}", primaryData);
55-
5655
sendExtMsg(new ProvidePrimaryData(tick, primaryData, maybeNextTick));
5756
}
5857
}

src/main/java/edu/ie3/simona/api/data/container/ExtInputContainer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public long getTick() {
6565
return tick;
6666
}
6767

68-
/** Returns an option for the next tick, where data will be provided. */
68+
/** Returns an option for the next tick, when data will be provided. */
6969
public Optional<Long> getMaybeNextTick() {
7070
return maybeNextTick;
7171
}

src/main/java/edu/ie3/simona/api/data/container/ExtResultContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public final class ExtResultContainer implements ExtDataContainer {
2727
/** Tick for which the results are meant for. */
2828
private final long tick;
2929

30-
/** Tick where the external simulation can expect the next results from SIMONA. */
30+
/** Tick when the external simulation can expect the next results from SIMONA. */
3131
private final Optional<Long> maybeNextTick;
3232

3333
/**
@@ -94,7 +94,7 @@ public long getTick() {
9494
return tick;
9595
}
9696

97-
/** Returns an option for the next tick, where data will be provided. */
97+
/** Returns an option for the next tick, when data will be provided. */
9898
public Optional<Long> getMaybeNextTick() {
9999
return maybeNextTick;
100100
}

0 commit comments

Comments
 (0)