Skip to content

Commit c3d7d45

Browse files
authored
Enable http2 in conformance-stable tests (#56)
1 parent 9462a3e commit c3d7d45

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ This simplifies overall setup: simpler CI, fewer network components, faster exec
5959
## Features of the protocol supported by the library
6060

6161
```yaml
62-
versions: [ HTTP_VERSION_1 ]
62+
versions: [ HTTP_VERSION_1, HTTP_VERSION_2 ]
6363
protocols: [ PROTOCOL_CONNECT ]
6464
codecs: [ CODEC_JSON, CODEC_PROTO ]
6565
stream_types: [ STREAM_TYPE_UNARY ]
@@ -100,6 +100,7 @@ val httpServer: Resource[IO, org.http4s.server.Server] = {
100100
httpServer <- EmberServerBuilder.default[IO]
101101
.withHost(host"0.0.0.0")
102102
.withPort(port"8080")
103+
.withHttp2 // If you want to enable HTTP2 support
103104
.withHttpApp(httpApp)
104105
.build
105106
} yield httpServer
@@ -150,13 +151,13 @@ Diagnostic data from the server itself is written to the log file `out/out.log`.
150151

151152
### Connect protocol conformance tests status
152153

153-
✅ JSON codec conformance status: __79/79__ tests pass.
154+
✅ JSON codec conformance status: __full conformance__.
154155

155156
⌛ Protobuf codec conformance status: __13/72__ tests pass.
156157

157158
Known issues:
158159

159-
~~* Response headers are ignored in case of an error from the server~~
160+
* Errors serialized incorrectly for protobuf codec.
160161

161162
## Future improvements
162163

conformance-suite-stable.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# https://github.com/connectrpc/conformance/blob/main/docs/configuring_and_running_tests.md#configuration-files
22
features:
3-
versions: [ HTTP_VERSION_1 ]
3+
versions: [ HTTP_VERSION_1, HTTP_VERSION_2 ]
44
protocols: [ PROTOCOL_CONNECT ]
55
codecs: [ CODEC_JSON ]
66
stream_types: [ STREAM_TYPE_UNARY ]

conformance/src/main/scala/org/ivovk/connect_rpc_scala/conformance/Main.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ object Main extends IOApp.Simple {
5858
server <- EmberServerBuilder.default[IO]
5959
.withHost(host"127.0.0.1")
6060
.withPort(port"0") // random port
61+
.withHttp2
6162
.withHttpApp(logger)
6263
.build
6364

0 commit comments

Comments
 (0)