Merge pull request #10 from ilyasudakov/develop

Develop

Author: ilyasudakov

bin/setup.js

@@ -177,7 +177,10 @@ const apps = {
 };
 
 function checkAppVersion(minimalVersion, app) {
-  const curApp = apps[app] ?? apps['node'];
+  let curApp = apps[app];
+  if (apps[app] === undefined) {
+    curApp = apps['node'];
+  }
   return new Promise((resolve, reject) => {
     exec(curApp.command, (err, stdout) => {
       const version = stdout.trim();
@@ -239,7 +242,6 @@ function reportError(error) {
 
   await installPackages().catch((reason) => reportError(reason));
   await removeFilesFromDirectory('bin/').catch((reason) => reportError(reason));
-  await removeFilesFromDirectory('public/assets/logo.png').catch((reason) => reportError(reason));
 
   if (repoRemoved) {
     process.stdout.write('\n');

readme.md

@@ -25,7 +25,7 @@ GitHub Action - for Continous Integration<br>
 Clone the repository
 
 ```
-git clone https://github.com/ilyasudakov/basic-react-boilerplate.git <YOUR_PROJECT_NAME>
+git clone https://github.com/ilyasudakov/react-base.git <YOUR_PROJECT_NAME>
 
 cd <YOUR_PROJECT_NAME>
 ```
@@ -60,22 +60,21 @@ You can run commands bellow manually, or they will run automatically with pre-co
 
 - TypeScript
 
-### In Plans
-
-- ...
-
 ### Maybe?
 
 - React DnD
 - Some Animation library
-- Material UI
 
 ## Questions
 
 - Q: Why no Redux?
 
   A: Too much boilercode, hard to maintain and slow to code. Rather use React-Query, which fetches, parses, caches data for you. Or in case if you need global storage for your app, React Context will probably do fine , but in huge apps where global state changes frequently - Redux is probably better option
 
+- Q: Why use this instead of Create-React-App?
+
+  A: CRA is really cool, but it becomes really frustrating when you want to customize project setup, configs, and here everything is easily accessible
+
 - Q: Why use this exact boilerplate?
 
   A: This is perfect barebones boilerplate i wanted in my development, which could be helpful for you. Its pretty much just a skeleton, so you can build up your own structure and project. I hope this project gives pretty quick start to code stuff