treat missing asyncs as errors!

Author: Sebastian Provenzano

eslint.config.mjs

@@ -24,7 +24,7 @@ export default tseslint.config(
       "@typescript-eslint/no-unsafe-member-access": "warn",
       "@typescript-eslint/dot-notation": "warn",
       "@typescript-eslint/no-explicit-any": "warn",
-      "@typescript-eslint/no-floating-promises": "warn"
+      "@typescript-eslint/no-floating-promises": "error"
     }
   },
   {

src/commands/implementations.ts

@@ -118,13 +118,13 @@ ${body}
   panel.webview.html = html;
 }
 
-export function checkAll(getClient: () => LanguageClient) {
+export async function checkAll(getClient: () => LanguageClient) {
   if (!getClient()) {
     return undefined;
   }
   const file_uri = window.activeTextEditor?.document.uri;
   if (getClient() && getClient().isRunning() && file_uri?.scheme === "file") {
-    getClient().sendRequest("workspace/executeCommand", { "command": "check-all", "arguments": [file_uri.toString()] });
+    await getClient().sendRequest("workspace/executeCommand", { "command": "check-all", "arguments": [file_uri.toString()] });
   }
 }
 
@@ -157,9 +157,9 @@ export function terminal_eval_selection(): boolean {
   return true;
 }
 
-export function clear_cache(getClient: () => LanguageClient) {
+export async function clear_cache(getClient: () => LanguageClient) {
   if (getClient()?.isRunning()) {
-    getClient().sendRequest("workspace/executeCommand", { "command": "clear-cache", "arguments": [] });
+    await getClient().sendRequest("workspace/executeCommand", { "command": "clear-cache", "arguments": [] });
   }
   return true;
 }

src/commands/registration.ts

@@ -13,7 +13,7 @@ export function register(context: ExtensionContext, imandraxLanguageClient: Iman
   context.subscriptions.push(commands.registerCommand(restart_cmd, restart_handler));
 
   const check_all_cmd = "imandrax.check_all";
-  const check_all_handler = () => { implementations.checkAll(getClient); };
+  const check_all_handler = async () => { await implementations.checkAll(getClient); };
   context.subscriptions.push(commands.registerCommand(check_all_cmd, check_all_handler));
 
   const browse_cmd = "imandrax.browse";
@@ -33,7 +33,7 @@ export function register(context: ExtensionContext, imandraxLanguageClient: Iman
   context.subscriptions.push(commands.registerCommand(terminal_eval_selection_cmd, terminal_eval_selection_handler));
 
   const clear_cache_cmd = "imandrax.clear_cache";
-  const clear_cache_handler = () => { implementations.clear_cache(getClient); };
+  const clear_cache_handler = async () => { await implementations.clear_cache(getClient); };
   context.subscriptions.push(commands.registerCommand(clear_cache_cmd, clear_cache_handler));
 
   const open_vfs_file_cmd = "imandrax.open_vfs_file";