refactor: remove default value for optional parmaters & make cluster name configurable

Author: Rahul-4480

examples/complete/README.md

@@ -14,6 +14,7 @@ atlantis_repo_allowlist        = ["repo1", "repo2"]
 # Optional Parameters
 thumbprint_list                = ["oidc-thumbprint-1", "oidc-thumbprint-2"]
 atlantis_docker_image =        = "<your-custom-docker-image>"
+ecs_cluster_name               = "<your-ecs-cluster-name>"
 ```
 
 ## Requirements

examples/complete/main.tf

@@ -6,6 +6,9 @@ module "atlantis" {
   atlantis_gh_user        = var.atlantis_gh_user
   atlantis_repo_allowlist = var.atlantis_repo_allowlist
   atlantis_url            = var.atlantis_url
-  thumbprint_list         = var.thumbprint_list
-  atlantis_docker_image   = var.atlantis_docker_image
+
+  # Optional variables
+  thumbprint_list       = var.thumbprint_list
+  atlantis_docker_image = var.atlantis_docker_image
+  ecs_cluster_name      = var.ecs_cluster_name
 }

examples/complete/variables.tf

@@ -28,14 +28,18 @@ variable "atlantis_url" {
   type        = string
 }
 
+# Optional variables defination
 variable "thumbprint_list" {
   description = "List of thumbprints for the OIDC provider"
   type        = list(string)
-  default     = ["e252aa6e92432f32cbc1b182056627c239652678"]
 }
 
 variable "atlantis_docker_image" {
   description = "The Docker image to use for the Atlantis server"
   type        = string
-  default     = "ghcr.io/runatlantis/atlantis:v0.23.1"
+}
+
+variable "ecs_cluster_name" {
+  description = "The name of the ECS cluster"
+  type        = string
 }