update: architectural diagram & remove public ip for launch template

Rahul-4480 · Rahul-4480 · commit b67b55062bd2 · 2024-07-28T13:09:05.000+05:30
diff --git a/.header.md b/.header.md
@@ -1,7 +1,15 @@
-# Terraform Module to Setup Atlantis in ECS with Self-Managed EC2 Instances
+# terraform-aws-atlantis
 
 This Terraform module automates the deployment of the Atlantis server on an ECS cluster with self-managed EC2 instances. It includes the configuration of an Application Load Balancer (ALB) for traffic routing. The module simplifies the process of setting up and managing Atlantis, enabling automated Terraform pull request workflows.
 
+---
+
+### Architectural Diagram
+
+![atlantis](https://github.com/user-attachments/assets/0252b4a9-38e3-4e8d-9212-fcfc091001a4)
+
+---
+
 ## Prerequisites
 
 - Domain with ACM certificate attached
diff --git a/modules/ecs/launch-template.tf b/modules/ecs/launch-template.tf
@@ -11,9 +11,8 @@ EOF
   )
 
   network_interfaces {
-    associate_public_ip_address = true
-    subnet_id                   = var.private_subnet_ids[0]
-    security_groups             = [aws_security_group.this.id]
+    subnet_id       = var.private_subnet_ids[0]
+    security_groups = [aws_security_group.this.id]
   }
 
   iam_instance_profile {

Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,8 @@ EOF`
`11`	`11`	`)`
`12`	`12`
`13`	`13`	`network_interfaces {`
`14`		`- associate_public_ip_address = true`
`15`		`- subnet_id = var.private_subnet_ids[0]`
`16`		`- security_groups = [aws_security_group.this.id]`
	`14`	`+ subnet_id = var.private_subnet_ids[0]`
	`15`	`+ security_groups = [aws_security_group.this.id]`
`17`	`16`	`}`
`18`	`17`
`19`	`18`	`iam_instance_profile {`