* (Apollon77) make sure userdata objects/states are not overwritten on createState

Author: Apollon77

README.md

@@ -36,6 +36,9 @@ And then call "npm run build".
 
 ## Changelog
 
+### __WORK IN PROGRESS__
+* (Apollon77) make sure userdata objects/states are not overwritten on createState 
+
 ### 4.6.19 (2020-07-26)
 * (Apollon77) Prevent wrong errors when setting "null" values for states
 * (Apollon77) Prevent potential crash when no typings could be found (Sentry IOBROKER-JAVASCRIPT-2T)

lib/sandbox.js

@@ -1829,75 +1829,47 @@ function sandBox(script, name, verbose, debug, context) {
 
             sandbox.verbose && sandbox.log('createState(name=' + name + ', initValue=' + initValue + ', forceCreation=' + forceCreation + ', common=' + JSON.stringify(common) + ', native=' + JSON.stringify(native) + ')', 'debug');
 
-            adapter.getObject(name, function (err, obj) {
+            let id = adapter.namespace + '.' + name;
+            if (name.match(/^javascript\.\d+\./) || name.startsWith('0_userdata.0.')) {
+                id = name;
+            }
+            adapter.getForeignObject(id, function (err, obj) {
                 if (err || !obj || forceCreation) {
                     // todo: store object in objects to have this object directly after callback
                     // create new one
-                    if (name.match(/^javascript\.\d+\./) || name.startsWith('0_userdata.0.')) {
-                        adapter.setForeignObject(name, {
-                            common: common,
-                            native: native,
-                            type:   'state'
-                        }, function (err) {
-                            err && adapter.log.warn('Cannot set object "' + name + '": ' + err);
-
-                            if (initValue !== undefined) {
-                                if (isObject(initValue) && initValue.ack !== undefined) {
-                                    adapter.setForeignState(name, initValue, callback);
-                                } else {
-                                    adapter.setForeignState(name, initValue, true, callback);
-                                }
-                            } else if (!forceCreation) {
-                                adapter.setForeignState(name, null, true, callback);
+                    adapter.setForeignObject(id, {
+                        common: common,
+                        native: native,
+                        type:   'state'
+                    }, function (err) {
+                        err && adapter.log.warn('Cannot set object "' + id + '": ' + err);
+
+                        if (initValue !== undefined) {
+                            if (isObject(initValue) && initValue.ack !== undefined) {
+                                adapter.setForeignState(id, initValue, callback);
                             } else {
-                                if (typeof callback === 'function') {
-                                    try {
-                                        callback.call(sandbox, name);
-                                    } catch (e) {
-                                        errorInCallback(e); //adapter.log.error('Error in callback: ' + e)
-                                    }
-                                }
+                                adapter.setForeignState(id, initValue, true, callback);
                             }
-                        });
-                    } else {
-                        adapter.setObject(name, {
-                            common: common,
-                            native: native,
-                            type:   'state'
-                        }, function (err) {
-                            err && adapter.log.warn('Cannot set object "' + name + '": ' + err);
-
-                            if (initValue !== undefined) {
-                                if (isObject(initValue) && initValue.ack !== undefined) {
-                                    adapter.setState(name, initValue, callback);
-                                } else {
-                                    adapter.setState(name, initValue, true, callback);
-                                }
-                            } else if (!forceCreation) {
-                                adapter.setState(name, null, true, callback);
-                            } else {
-                                if (typeof callback === 'function') {
-                                    try {
-                                        callback.call(sandbox, name);
-                                    } catch (e) {
-                                        errorInCallback(e); //adapter.log.error('Error in callback: ' + e)
-                                    }
+                        } else if (!forceCreation) {
+                            adapter.setForeignState(id, null, true, callback);
+                        } else {
+                            if (typeof callback === 'function') {
+                                try {
+                                    callback.call(sandbox, id);
+                                } catch (e) {
+                                    errorInCallback(e); //adapter.log.error('Error in callback: ' + e)
                                 }
                             }
-                        });
-                    }
-                } else {
-                    if (!adapter.config.subscribe && !states[name] && states[adapter.namespace + '.' + name] === undefined) {
-                        if (!name.startsWith(adapter.namespace)) {
-                            states[adapter.namespace + '.' + name] = {val: null, ack: true};
-                        } else {
-                            states[name] = {val: null, ack: true};
                         }
+                    });
+                } else {
+                    if (!adapter.config.subscribe && !states[id] && states[adapter.namespace + '.' + id] === undefined) {
+                        states[id] = {val: null, ack: true};
                     }
                     // state yet exists
                     if (typeof callback === 'function') {
                         try {
-                            callback.call(sandbox, name);
+                            callback.call(sandbox, id);
                         } catch (e) {
                             errorInCallback(e); //adapter.log.error('Error in callback: ' + e)
                         }