* (Apollon77) Catch error case when npm istallation fails (Sentry IOBROKER-JAVASCRIPT-3K)

* (Apollon77) Prevent crash case in mirroring (Sentry IOBROKER-JAVASCRIPT-3M)

Author: Apollon77

README.md

@@ -39,6 +39,10 @@ And then call "npm run build".
     ### __WORK IN PROGRESS__
 -->
 ## Changelog
+### __WORK IN PROGRESS__
+* (Apollon77) Catch error case when npm istallation fails (Sentry IOBROKER-JAVASCRIPT-3K)
+* (Apollon77) Prevent crash case in mirroring (Sentry IOBROKER-JAVASCRIPT-3M)
+
 ### 4.6.25 (2020-08-24)
 * (bluefox) Fixed the loading of page
 

lib/mirror.js

@@ -222,6 +222,10 @@ class Mirror {
                     if (objects[o] === files[f]) {
                         const id = dirDB + '.' + objects[o];
 
+                        if (!this.diskList[id]) {
+                            continue;
+                        }
+
                         if (!this.dbList[id].ts || (this.dbList[id].ts > this.diskList[id].ts && this.dbList[id].ts - this.diskList[id].ts > 2000)) {
                             // copy text to file
                             this.dbList[id].ts = Date.now();

main.js

@@ -1214,12 +1214,19 @@ function installNpm(npmLib, callback) {
     child.stderr.on('data', buf =>
         adapter.log.error(buf.toString('utf8')));
 
+    child.on('err', err => {
+        adapter.log.error('Cannot install ' + npmLib + ': ' + err);
+        if (typeof callback === 'function') callback(npmLib);
+        callback = null;
+    });
+
     child.on('exit', (code /* , signal */) => {
         if (code) {
             adapter.log.error('Cannot install ' + npmLib + ': ' + code);
         }
         // command succeeded
         if (typeof callback === 'function') callback(npmLib);
+        callback = null;
     });
 }
 

package.json

@@ -30,7 +30,7 @@
   },
   "dependencies": {
     "@iobroker/adapter-core": "^2.4.0",
-    "@types/node": "^10.17.28",
+    "@types/node": "^12.12.54",
     "@types/request": "^2.48.5",
     "coffee-compiler": "^0.3.2",
     "coffee-script": "^1.12.7",