fix: correct file existence check

Signed-off-by: Gerard Vanloo <gerard.vanloo@ibm.com>

Author: Red-GV

sre/playbooks/manage_applications.yaml

@@ -50,6 +50,8 @@
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               status: progressing
 
@@ -66,13 +68,17 @@
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               status: succeeded
       rescue:
         - name: Import leaderboard role
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               failed_task:
                 name: "{{ ansible_failed_task.name }}"

sre/playbooks/manage_incidents.yaml

@@ -47,6 +47,8 @@
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               status: progressing
 
@@ -98,13 +100,17 @@
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               status: succeeded
       rescue:
         - name: Import leaderboard role
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               failed_task:
                 name: "{{ ansible_failed_task.name }}"

sre/playbooks/manage_tools.yaml

@@ -59,6 +59,8 @@
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               status: progressing
 
@@ -75,13 +77,17 @@
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               status: succeeded
       rescue:
         - name: Import leaderboard role
           ansible.builtin.import_role:
             name: leaderboard
           vars:
+            leaderboard_incident:
+              id: "{{ incident_id }}"
             leaderboard_status:
               failed_task:
                 name: "{{ ansible_failed_task.name }}"

sre/roles/leaderboard/meta/argument_specs.yaml

@@ -8,6 +8,13 @@ argument_specs:
     author:
       - Gerard Vanloo
     options:
+      leaderboard_incident:
+        required: false
+        type: dict
+        options:
+          id:
+            required: true
+            type: int
       leaderboard_status:
         required: true
         type: dict

sre/roles/leaderboard/tasks/create_status.yaml

@@ -1,21 +1,21 @@
 ---
 - name: Create leaderboard status content
   ansible.builtin.set_fact:
-    leaderboard_status:
-      incident: "{{ leaderboard_incident.id | default('') }}"
+    leaderboard_current_status:
+      incident: "{{ leaderboard_incident.id | default(omit) }}"
       events: []
-    leaderboard_status_legacy:
+    leaderboard_legacy_status:
       status:
         conditions: []
 
 - name: Create status file in legacy format
   ansible.builtin.copy:
-    content: "{{ leaderboard_status_legacy | to_nice_json(indent=2) }}"
+    content: "{{ leaderboard_legacy_status | to_nice_json(indent=2) }}"
     dest: "/tmp/status_legacy.json"
     mode: "0644"
 
 - name: Create status file in v1 format
   ansible.builtin.copy:
-    content: "{{ leaderboard_status_legacy | to_nice_json }}"
+    content: "{{ leaderboard_current_status | to_nice_json }}"
     dest: "/tmp/status.json"
     mode: "0644"

sre/roles/leaderboard/tasks/main.yaml

@@ -5,9 +5,15 @@
   tags:
     - install_tools
 
+- name: Verify that the status file exists
+  ansible.builtin.set_fact:
+    leaderboard_status_exists: "{{ '/tmp/status.json' is exists }}"
+  tags:
+    - always
+
 - name: Perform update tasks
   when:
-    - /tmp/status.json is exists
+    - leaderboard_status_exists
   block:
     - name: Import status file update tasks
       ansible.builtin.import_tasks: