Merge pull request #45 from pistolingo/fix-startStringScroll

Fix startStringScroll for non _p strings with length <= MAXDIGITS

Author: jasonacox

RELEASE.md

@@ -1,5 +1,9 @@
 # Release Notes for TM1637TinyDisplay
 
+## v1.12.1 - startStringScroll Fix
+
+* Fix startStringScroll for non _p strings with length <= MAXDIGITS by @pistolingo in https://github.com/jasonacox/TM1637TinyDisplay/pull/45
+
 ## v1.12.0 - Clear Display Option
 
 * Update `begin()` function to allow parameter control of display clear and full brightness setting. Default behavior if not specified will be `true` which is the behavior with prior version.

TM1637TinyDisplay.cpp

@@ -680,7 +680,7 @@ void TM1637TinyDisplay::startStringScroll(const char s[], unsigned int ms, bool
         m_animation_frames = strlen(s);
         if (m_animation_frames <= MAXDIGITS) {
             // no need to scroll, just display it
-            showString_P(s, m_animation_frames, 0, 0);
+            showString(s, m_animation_frames, 0, 0);
             return;
         } else {
             m_animation_type = 4;

TM1637TinyDisplay6.cpp

@@ -683,7 +683,7 @@ void TM1637TinyDisplay6::startStringScroll(const char s[], unsigned int ms, bool
         m_animation_frames = strlen(s);
         if (m_animation_frames <= MAXDIGITS) {
             // no need to scroll, just display it
-            showString_P(s, m_animation_frames, 0, 0);
+            showString(s, m_animation_frames, 0, 0);
             return;
         } else {
             m_animation_type = 4;

examples/TM1637-6Digit-NonBlockingAnimate/TM1637-6Digit-NonBlockingAnimate.ino

@@ -156,6 +156,20 @@ void loop()
                 // non-blocking scrolling of a long string
                 display.startStringScroll(SRamString, 200);
                 break;
+            case 5:
+                Serial.println("");
+                Serial.println("Animated Short String Scroll from SRAM");
+                // non-blocking scrolling of a short string
+                display.startStringScroll("S-Test", 200);
+                delay(TEST_DELAY);
+                break;
+            case 6:
+                Serial.println("");
+                Serial.println("Animated Short String Scroll from PROGMEM");
+                // non-blocking scrolling of a short string
+                display.startStringScroll_P("F-Test", 200);
+                delay(TEST_DELAY);
+                break;
             default:
                 display.showString("The");
                 delay(TEST_DELAY);

examples/TM1637-NonBlockingAnimate/TM1637-NonBlockingAnimate.ino

@@ -167,6 +167,20 @@ void loop()
         // non-blocking scrolling of a long string
         display.startStringScroll(SRamString, 200);
         break;
+      case 5:
+        Serial.println("");
+        Serial.println("Animated Short String Scroll from SRAM");
+        // non-blocking scrolling of a short string
+        display.startStringScroll("SRAM", 200);
+        delay(TEST_DELAY);
+        break;
+      case 6:
+        Serial.println("");
+        Serial.println("Animated Short String Scroll from PROGMEM");
+        // non-blocking scrolling of a short string
+        display.startStringScroll_P("FLAS", 200);
+        delay(TEST_DELAY);
+        break;
       default:
         display.showString("The");
         delay(TEST_DELAY);

library.json

@@ -1,6 +1,6 @@
 {
   "name": "TM1637TinyDisplay",
-  "version": "1.10.0",
+  "version": "1.12.1",
   "keywords": "TM1637, tiny, LED, display",
   "description": "A simple library to display numbers, text and animation on a 4 and 6 digit 7-segment TM1637 based display modules. Offers non-blocking animations and scrolling!",
   "repository": {

library.properties

@@ -1,5 +1,5 @@
 name=TM1637TinyDisplay
-version=1.12.0
+version=1.12.1
 author=Jason Cox <jason@jasonacox.com>
 maintainer=Jason Cox <jason@jasonacox.com>
 sentence=A simple library to display numbers, text and animation on 4 and 6 digit 7-segment TM1637 based display modules. Offers non-blocking animations and scrolling!