Proposed fix for release bug #2647 (#217)

* Adding a small positive minimum value to the QML form for the prior parameters; checking for non-positive prior parameters when parsing the options in R

* adding conditional on the new error checks to get past unit tests

* adding unit tests to check for illegal prior parameter error handlig

* setting 'inclusive: 0' in the FormulaFields to enforce strictly positive prior parameters

* Apply suggestions from code review

Use false instead of 0

* Use JASP.None for inclusive property

---------

Co-authored-by: bruno boutin <b.boutin@uva.nl>

Author: kylelang

R/LSbinaryclassification.R

@@ -89,6 +89,16 @@ LSbinaryclassification <- function(jaspResults, dataset, options, state = NULL)
     "falseNegative", "trueNegative", "falsePositive", "truePositive")
     )
 
+  priorParms <- options[grep("^prior\\w+[Alpha,Beta]$", names(options))] |>
+    unlist() |>
+    na.omit()
+
+  if(!is.null(priorParms) && length(priorParms) > 0 && !all(priorParms > 0))
+    gettextf(
+      "JAGS requires strictly positive parameters for Beta priors. Set {\u03B1, \u03B2} > 0 for the prior distributions of Prevalence, Sensitivity, and Specificity."
+      ) |>
+      jaspBase::.quitAnalysis()
+
   if(options[["inputType"]] == "pointEstimates") options[["ci"]] <- FALSE
 
   colors <- .bcGetColors(options)[["values"]]

inst/qml/LSbinaryclassification.qml

@@ -20,6 +20,7 @@ import QtQuick.Layouts 1.3
 import JASP.Controls 1.0
 import JASP.Widgets 1.0
 import JASP.Theme 1.0
+import JASP
 import "../qml/qml_components" as LS
 
 Form {
@@ -46,17 +47,79 @@ Form {
 		visible: inputType.value === "uncertainEstimates" || inputType.value === "data"
 		columns: 3
 		title: qsTr("Priors")
+
 		Text{ text: qsTr("Prevalence") }
-		FormulaField { name: "priorPrevalenceAlpha";  label: qsTr("~ Beta(α = ");		afterLabel: ",";		min: 0; defaultValue: "1"	; fieldWidth: 65}
-		FormulaField { name: "priorPrevalenceBeta";   label: "β = ";								afterLabel: qsTr(")");	min: 0; defaultValue: "9"; fieldWidth: 65	}
+
+		FormulaField
+		{
+			name:			"priorPrevalenceAlpha"
+			label:			qsTr("~ Beta(α = ")
+			afterLabel:		","
+			min:			0
+			inclusive:		JASP.None
+			defaultValue:	"1"
+			fieldWidth:		65
+		}
+
+		FormulaField
+		{
+			name:			"priorPrevalenceBeta"
+			label:			"β = "
+			afterLabel:		qsTr(")");
+			min:			0
+			inclusive:		JASP.None
+			defaultValue:	"9"
+			fieldWidth:		65
+		}
 
 		Text{ text: qsTr("Sensitivity") }
-		FormulaField { name: "priorSensitivityAlpha"; label: qsTr("~ Beta(α = ");	afterLabel: ",";		min: 0; defaultValue: "8"; fieldWidth: 65	}
-		FormulaField { name: "priorSensitivityBeta";  label: "β = ";								afterLabel: qsTr(")");	min: 0; defaultValue: "2"; fieldWidth: 65	}
+
+		FormulaField
+		{
+			name:			"priorSensitivityAlpha"
+			label:			qsTr("~ Beta(α = ")
+			afterLabel:		","
+			min:			0
+			inclusive:		JASP.None
+			defaultValue:	"8"
+			fieldWidth:		65
+		}
+
+		FormulaField
+		{
+			name:			"priorSensitivityBeta"
+			label:			"β = "
+			afterLabel:		qsTr(")")
+			min:			0
+			inclusive:		JASP.None
+			defaultValue:	"2"
+			fieldWidth:		65
+		}
 
 		Text{ text: qsTr("Specificity") }
-		FormulaField { name: "priorSpecificityAlpha"; label: qsTr("~ Beta(α = ");	afterLabel: ",";		min: 0; defaultValue: "8"; fieldWidth: 65	}
-		FormulaField { name: "priorSpecificityBeta";  label: "β = ";								afterLabel: qsTr(")");	min: 0; defaultValue: "2"; fieldWidth: 65	}
+
+		FormulaField
+		{
+			name:			"priorSpecificityAlpha"
+			label:			qsTr("~ Beta(α = ")
+			afterLabel:		","
+			min:			0
+			inclusive:		JASP.None
+			defaultValue:	"8"
+			fieldWidth:		65
+		}
+
+		FormulaField
+		{
+			name:			"priorSpecificityBeta"
+			label:			"β = "
+			afterLabel:		qsTr(")")
+			min:			0
+			inclusive:		JASP.None
+			defaultValue:	"2"
+			fieldWidth:		65
+		}
+
 	}
 
 	Group