-
-
Notifications
You must be signed in to change notification settings - Fork 173
Description
in //DEPS we allow use of property replacement to support things like autodetected properties like ${os.detected.*} and user specified config ${quarkus.version}.
But we don't apply those when running as a scriptref.
Making
jbang https://github.com/HanSolo/jarkanoid/releases/download/17.0.17/jarkanoid-${os.detected.jfxname}-17.0.17.jar
not work....when it would be nice it could.
see https://github.com/HanSolo/jarkanoid/releases/download/17.0.17/jarkanoid-${os.detected.jfxname}-17.0.17.jar for the standard naming patterns
note, its not just https, jbang org.openjfx:javafx-graphics:11.0.2:${os.detected.jfxname}
fails too ...which it shouldn't imo given //DEPS
works.
writing this out i'm thinking more and more that on scriptref's we should apply property replacement before we pass it further down...though we don't want to loose the original value either - which is where i'm currently stomped.