Skip to content

Commit 0592749

Browse files
committed
bug fix
1 parent 41998ab commit 0592749

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# logitr (development version)
22

33
- Added a startup message when the package is loaded
4+
- Fixed bug in adjustFactorLevels where the levels_orig object was being accidentally overwritten
45

56
# logitr 1.0.0
67

R/predict.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,9 @@ adjustFactorLevels <- function(object, newdata) {
152152
for (i in 1:length(factorLevels)) {
153153
par <- names(factorLevels)[[i]]
154154
levels_new <- factorLevels[[i]]
155-
levels_orig <- levels_orig[[par]]
156-
if (! identical(levels_new, levels_orig)) {
157-
newdata[[par]] <- factor(newdata[[par]], levels = levels_orig)
155+
levels_old <- levels_orig[[par]]
156+
if (! identical(levels_new, levels_old)) {
157+
newdata[[par]] <- factor(newdata[[par]], levels = levels_old)
158158
}
159159
}
160160
}

0 commit comments

Comments
 (0)