Skip to content

Commit 8c14336

Browse files
jirka.pinkas@gmail.comjirka.pinkas@gmail.com
authored andcommitted
completely rewritten pingGoogle / pingBing methods ... tweaks
1 parent 239ba24 commit 8c14336

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ SitemapGenerator.of("https://example.com")
101101
// generate sitemap and save it to file ./sitemap.xml
102102
.toFile(Paths.get("sitemap.xml"))
103103
// inform Google that this sitemap has changed
104-
.pingGoogle(); // this requires okhttp in classpath!!!
104+
.ping(SearchEngine.GOOGLE); // this requires okhttp in classpath!!!
105105
```
106106

107107
### How to create sitemap index:

src/main/java/cz/jiripinkas/jsitemapgenerator/AbstractSitemapGenerator.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ public T toFile(File parent, String child) throws IOException {
210210
* @param sitemapUrl sitemap url
211211
*/
212212
public void ping(String sitemapUrl, SearchEngine ... searchEngines) {
213+
if(searchEngines.length == 0) {
214+
throw new UnsupportedOperationException("Must provide at least one search engine!");
215+
}
213216
for (SearchEngine searchEngine : searchEngines) {
214217
ping(searchEngine.getPingUrl(), sitemapUrl, searchEngine.getPrettyName());
215218
}
@@ -225,6 +228,9 @@ public void ping(String sitemapUrl, SearchEngine ... searchEngines) {
225228
* @return If operation succeeded
226229
*/
227230
public boolean ping(boolean doNotThrowExceptionOnFailure, SearchEngine ... searchEngines) {
231+
if(searchEngines.length == 0) {
232+
throw new UnsupportedOperationException("Must provide at least one search engine!");
233+
}
228234
try {
229235
ping(searchEngines);
230236
return true;
@@ -247,6 +253,9 @@ public boolean ping(boolean doNotThrowExceptionOnFailure, SearchEngine ... searc
247253
* @return If operation succeeded
248254
*/
249255
public boolean ping(String sitemapUrl, boolean doNotThrowExceptionOnFailure, SearchEngine... searchEngines) {
256+
if(searchEngines.length == 0) {
257+
throw new UnsupportedOperationException("Must provide at least one search engine!");
258+
}
250259
try {
251260
ping(sitemapUrl, searchEngines);
252261
return true;
@@ -264,6 +273,9 @@ public boolean ping(String sitemapUrl, boolean doNotThrowExceptionOnFailure, Sea
264273
* @param searchEngines Search engines to ping
265274
*/
266275
public void ping(SearchEngine ... searchEngines) {
276+
if(searchEngines.length == 0) {
277+
throw new UnsupportedOperationException("Must provide at least one search engine!");
278+
}
267279
ping(baseUrl + "sitemap.xml", searchEngines);
268280
}
269281

0 commit comments

Comments
 (0)