Skip to content

Commit ef2c949

Browse files
jirka.pinkas@gmail.comjirka.pinkas@gmail.com
authored andcommitted
cleanup
1 parent 8eb8327 commit ef2c949

File tree

4 files changed

+6
-15
lines changed

4 files changed

+6
-15
lines changed

src/main/java/cz/jiripinkas/jsitemapgenerator/AbstractGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,8 @@ public interface GeneratorConsumerWithException<T> {
240240
void accept(T t) throws Exception;
241241
}
242242

243-
public interface StringSupplierWithException<String> {
244-
String get() throws Exception;
243+
public interface StringSupplierWithException<S> {
244+
S get() throws Exception;
245245
}
246246

247247
/**

src/main/java/cz/jiripinkas/jsitemapgenerator/W3CDateFormat.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
/**
2-
*
3-
*/
41
package cz.jiripinkas.jsitemapgenerator;
52

63
import static java.util.Calendar.HOUR_OF_DAY;
@@ -52,7 +49,6 @@
5249
* @see <a href="http://www.w3.org/TR/NOTE-datetime">Date and Time Formats</a>
5350
*/
5451
public class W3CDateFormat extends SimpleDateFormat {
55-
private static final long serialVersionUID = -5733368073260485802L;
5652

5753
/** The six patterns defined by W3C, plus {@link #AUTO} configuration */
5854
public enum Pattern {

src/main/java/cz/jiripinkas/jsitemapgenerator/generator/SitemapGenerator.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,6 @@ private SitemapGenerator(String baseUrl) {
2323
super(baseUrl);
2424
}
2525

26-
/**
27-
* @param baseUrl Base URL
28-
* @param additionalNamespaces Additional parameters
29-
*/
30-
private SitemapGenerator(String baseUrl, AdditionalNamespace[] additionalNamespaces) {
31-
this(baseUrl);
32-
}
33-
3426
/**
3527
* Construct additional namespaces string
3628
* @param additionalNamespaceList

src/test/java/cz/jiripinkas/jsitemapgenerator/robots/RobotsRuleTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ public class RobotsRuleTest {
88

99
@Test
1010
public void testBuilderOK() {
11-
RobotsRule.builder().allowAll().userAgentAll().build();
11+
RobotsRule robotsRule = RobotsRule.builder().allowAll().userAgentAll().build();
12+
assertEquals("/", robotsRule.getAllows().get(0));
13+
assertEquals("*", robotsRule.getUserAgent());
14+
assertTrue(robotsRule.getDisallows().isEmpty());
1215
}
1316

1417
@Test(expected = RobotsRuleException.class)

0 commit comments

Comments
 (0)