Merge pull request #14 from karlmonson/master

joecampo · web-flow · commit 933cbb7af25e · 2019-03-16T09:03:31.000-04:00
Fixed a 'Division by Zero' error in the sleepIfRateLimited() method.
diff --git a/src/ShipStation.php b/src/ShipStation.php
@@ -127,7 +127,7 @@ public function sleepIfRateLimited(Response $response)
         $rateLimit = $response->getHeader('X-Rate-Limit-Remaining')[0];
         $rateLimitWait = $response->getHeader('X-Rate-Limit-Reset')[0];
 
-        if (($rateLimitWait / $rateLimit) > 1.5) {
+        if ($rateLimit === 0 || ($rateLimitWait / $rateLimit) > 1.5) {
             sleep(1.5);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public function sleepIfRateLimited(Response $response)`
`127`	`127`	`$rateLimit = $response->getHeader('X-Rate-Limit-Remaining')[0];`
`128`	`128`	`$rateLimitWait = $response->getHeader('X-Rate-Limit-Reset')[0];`
`129`	`129`
`130`		`- if (($rateLimitWait / $rateLimit) > 1.5) {`
	`130`	`+ if ($rateLimit === 0 \|\| ($rateLimitWait / $rateLimit) > 1.5) {`
`131`	`131`	`sleep(1.5);`
`132`	`132`	`}`
`133`	`133`	`}`