Skip to content

Commit d8b8eeb

Browse files
committed
Refactor external link markers, ensure they run on navigation.
See #654
1 parent 0b3079a commit d8b8eeb

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/js/mcjs.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
}
162162
});
163163
}
164-
164+
my_calendar_external_links();
165165
my_calendar_edit_toggles();
166166
mc_render_buttons();
167167
if ( 'true' === my_calendar.ajax ) {
@@ -278,6 +278,7 @@
278278
$('.mini .has-events').children().not('.mc-date-container').hide();
279279
}
280280
mc_render_buttons();
281+
my_calendar_external_links();
281282
my_calendar_edit_toggles();
282283
// All views.
283284
$( '#' + targetId ).trigger( 'focus' );
@@ -372,7 +373,13 @@
372373
}
373374
}
374375

375-
$('.mc-main a[target=_blank]').append( ' <span class="dashicons dashicons-external" aria-hidden="true"></span><span class="screen-reader-text"> ' + my_calendar.newWindow + '</span>' );
376+
function my_calendar_external_links() {
377+
let external_links = document.querySelectorAll('.mc-main a[target=_blank]');
378+
external_links.forEach( (el) => {
379+
el.classList.add( 'mc-opens-in-new-tab' );
380+
el.insertAdjacentHTML( 'beforeend', ' <span class="dashicons dashicons-external" aria-hidden="true"></span><span class="screen-reader-text"> ' + my_calendar.newWindow + '</span>' );
381+
});
382+
}
376383

377384
function my_calendar_edit_toggles() {
378385
const adminToggles = document.querySelectorAll( '.mc-toggle-edit' );

0 commit comments

Comments
 (0)