Skip to content

Commit fba65e7

Browse files
committed
replace mocha and nyc with native node test runner and c8
1 parent a63518a commit fba65e7

File tree

6 files changed

+38
-26
lines changed

6 files changed

+38
-26
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,14 @@ jobs:
7070
7171
- name: Run tests
7272
shell: bash
73-
run: |
74-
if npm -ps ls nyc | grep -q nyc; then
75-
npm run test-ci
76-
else
77-
npm test
78-
fi
73+
run: npm run test-ci
7974

8075
- name: Lint code
8176
if: steps.list_env.outputs.eslint != ''
8277
run: npm run lint
8378

8479
- name: Collect code coverage
8580
uses: coverallsapp/github-action@master
86-
if: steps.list_env.outputs.nyc != ''
8781
with:
8882
github-token: ${{ secrets.GITHUB_TOKEN }}
8983
flag-name: run-${{ matrix.test_number }}

package.json

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
],
1919
"repository": "jshttp/negotiator",
2020
"devDependencies": {
21+
"c8": "^10.1.2",
2122
"eslint": "7.32.0",
22-
"eslint-plugin-markdown": "2.2.1",
23-
"mocha": "9.1.3",
24-
"nyc": "15.1.0"
23+
"eslint-plugin-markdown": "2.2.1"
2524
},
2625
"files": [
2726
"lib/",
@@ -35,9 +34,8 @@
3534
},
3635
"scripts": {
3736
"lint": "eslint .",
38-
"test": "mocha --reporter spec --check-leaks --bail test/",
39-
"test:debug": "mocha --reporter spec --check-leaks --inspect --inspect-brk test/",
40-
"test-ci": "nyc --reporter=lcov --reporter=text npm test",
41-
"test-cov": "nyc --reporter=html --reporter=text npm test"
37+
"test": "node --test --test-reporter spec",
38+
"test-ci": "c8 --reporter=lcovonly --reporter=text npm test",
39+
"test-cov": "c8 --reporter=html --reporter=text npm test"
4240
}
4341
}

test/charset.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
1+
var nodeTest = require('node:test')
2+
var describe = nodeTest.describe
3+
var it = nodeTest.it
4+
var before = nodeTest.before
25
var assert = require('assert')
36
var Negotiator = require('..')
47

@@ -326,10 +329,12 @@ function whenAcceptCharset(acceptCharset, func) {
326329
: 'when Accept-Charset: ' + acceptCharset
327330

328331
describe(description, function () {
332+
var thisArg = {}
333+
329334
before(function () {
330-
this.negotiator = new Negotiator(createRequest({'Accept-Charset': acceptCharset}))
335+
thisArg.negotiator = new Negotiator(createRequest({'Accept-Charset': acceptCharset}))
331336
})
332337

333-
func()
338+
func.bind(thisArg)
334339
})
335340
}

test/encoding.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
1+
var nodeTest = require('node:test')
2+
var describe = nodeTest.describe
3+
var it = nodeTest.it
4+
var before = nodeTest.before
25
var assert = require('assert')
36
var Negotiator = require('..')
47

@@ -467,10 +470,12 @@ function whenAcceptEncoding(acceptEncoding, func) {
467470
: 'when Accept-Encoding: ' + acceptEncoding
468471

469472
describe(description, function () {
473+
var thisArg = {}
474+
470475
before(function () {
471-
this.negotiator = new Negotiator(createRequest({'Accept-Encoding': acceptEncoding}))
476+
thisArg.negotiator = new Negotiator(createRequest({'Accept-Encoding': acceptEncoding}))
472477
})
473478

474-
func()
479+
func.bind(thisArg)
475480
})
476481
}

test/language.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
1+
var nodeTest = require('node:test')
2+
var describe = nodeTest.describe
3+
var it = nodeTest.it
4+
var before = nodeTest.before
25
var assert = require('assert')
36
var Negotiator = require('..')
47

@@ -422,10 +425,12 @@ function whenAcceptLanguage(acceptLanguage, func) {
422425
: 'when Accept-Language: ' + acceptLanguage
423426

424427
describe(description, function () {
428+
var thisArg = {}
429+
425430
before(function () {
426-
this.negotiator = new Negotiator(createRequest({'Accept-Language': acceptLanguage}))
431+
thisArg.negotiator = new Negotiator(createRequest({'Accept-Language': acceptLanguage}))
427432
})
428433

429-
func()
434+
func.bind(thisArg)
430435
})
431436
}

test/mediaType.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
1+
var nodeTest = require('node:test')
2+
var describe = nodeTest.describe
3+
var it = nodeTest.it
4+
var before = nodeTest.before
25
var assert = require('assert')
36
var Negotiator = require('..')
47

@@ -490,10 +493,12 @@ function whenAccept(accept, func) {
490493
: 'when Accept: ' + accept
491494

492495
describe(description, function () {
496+
var thisArg = {}
497+
493498
before(function () {
494-
this.negotiator = Negotiator(createRequest({'Accept': accept}))
499+
thisArg.negotiator = Negotiator(createRequest({ 'Accept': accept }))
495500
})
496501

497-
func()
502+
func.bind(thisArg)
498503
})
499504
}

0 commit comments

Comments
 (0)