From c84eb894fc4969982c93b7cf10046006f2539a63 Mon Sep 17 00:00:00 2001
From: Milly <milly.ca@gmail.com>
Date: Sun, 11 Aug 2024 08:48:42 +0900
Subject: [PATCH] test[isRequiredOf]: add proper `true` or `false` cases

---
 is/required_of_test.ts | 47 ++++++++++++++++++++++++++++--------------
 1 file changed, 31 insertions(+), 16 deletions(-)

diff --git a/is/required_of_test.ts b/is/required_of_test.ts
index 3f638b4..9cb4e40 100644
--- a/is/required_of_test.ts
+++ b/is/required_of_test.ts
@@ -19,25 +19,31 @@ Deno.test("isRequiredOf<T>", async (t) => {
   });
 
   await t.step("returns true on Required<T> object", () => {
+    assertEquals(isRequiredOf(pred)({ a: 0, b: "a", c: true, d: "a" }), true);
     assertEquals(
-      isRequiredOf(pred)({ a: undefined, b: undefined, c: undefined }),
-      false,
-      "Object does not have required properties",
-    );
-    assertEquals(
-      isRequiredOf(pred)({}),
-      false,
-      "Object does not have required properties",
+      isRequiredOf(pred)({ a: 0, b: undefined, c: true, d: "a" }),
+      true,
+      "Union type contains 'undefined'",
     );
   });
 
   await t.step("returns false on non Required<T> object", () => {
     assertEquals(isRequiredOf(pred)("a"), false, "Value is not an object");
     assertEquals(
-      isRequiredOf(pred)({ a: 0, b: "a", c: "" }),
+      isRequiredOf(pred)({ a: 0, b: "a", c: 0, d: "a" }),
       false,
       "Object have a different type property",
     );
+    assertEquals(
+      isRequiredOf(pred)({ a: 0, b: "a", d: "a" }),
+      false,
+      "Object does not have required properties",
+    );
+    assertEquals(
+      isRequiredOf(pred)({ a: 0, b: "a", c: undefined, d: "a" }),
+      false,
+      "Optional property that converted to required is 'undefined'",
+    );
   });
 
   await t.step("predicated type is correct", () => {
@@ -69,24 +75,33 @@ Deno.test("isRequiredOf<T>", async (t) => {
 
     await t.step("returns true on Required<T> object", () => {
       assertEquals(
-        isRequiredOf(pred)({ a: undefined, [b]: undefined, [c]: undefined }),
-        false,
-        "Object does not have required properties",
+        isRequiredOf(pred)({ a: 0, [b]: "a", [c]: true, [d]: "a" }),
+        true,
       );
       assertEquals(
-        isRequiredOf(pred)({}),
-        false,
-        "Object does not have required properties",
+        isRequiredOf(pred)({ a: 0, [b]: undefined, [c]: true, [d]: "a" }),
+        true,
+        "Union type contains 'undefined'",
       );
     });
 
     await t.step("returns false on non Required<T> object", () => {
       assertEquals(isRequiredOf(pred)("a"), false, "Value is not an object");
       assertEquals(
-        isRequiredOf(pred)({ a: 0, [b]: "a", [c]: "" }),
+        isRequiredOf(pred)({ a: 0, [b]: "a", [c]: 0, [d]: "a" }),
         false,
         "Object have a different type property",
       );
+      assertEquals(
+        isRequiredOf(pred)({ a: 0, [b]: "a", [d]: "a" }),
+        false,
+        "Object does not have required properties",
+      );
+      assertEquals(
+        isRequiredOf(pred)({ a: 0, [b]: "a", [c]: undefined, [d]: "a" }),
+        false,
+        "Optional property that converted to required is 'undefined'",
+      );
     });
 
     await t.step("predicated type is correct", () => {