Skip to content

Commit 2e4bc40

Browse files
committed
update centerAboveOrBelow placement strategy,
install new version of react-measure, bump version
1 parent 7753855 commit 2e4bc40

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-text-selection-popover",
3-
"version": "1.0.3",
3+
"version": "1.1.0",
44
"description": "",
55
"author": "juliankrispel",
66
"license": "MIT",
@@ -30,7 +30,7 @@
3030
"dependencies": {
3131
"lodash.debounce": "^4.0.8",
3232
"react-event-listener": "^0.6.1",
33-
"react-measure": "juliankrispel/react-measure#proptype-release",
33+
"react-measure": "^2.1.2",
3434
"react-window-dimensions": "^1.0.2",
3535
"rollup-plugin-copy": "^0.2.3"
3636
},

src/centerAboveOrBelow.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export default ({
2020
selectionTop,
2121
selectionLeft,
2222
selectionWidth,
23-
/* selectionHeight */
23+
selectionHeight
2424
}) => {
2525
const style = { position: "fixed" };
2626

@@ -39,7 +39,7 @@ export default ({
3939

4040
// if the popover is placed above the frame, position below selection instead
4141
if (style.top < frameTop) {
42-
style.top = selectionTop + gap;
42+
style.top = selectionTop + selectionHeight + gap;
4343
}
4444

4545
return style;

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6119,9 +6119,9 @@ react-event-listener@^0.6.1:
61196119
prop-types "^15.6.0"
61206120
warning "^4.0.1"
61216121

6122-
react-measure@juliankrispel/react-measure#proptype-release:
6123-
version "2.1.0"
6124-
resolved "https://codeload.github.com/juliankrispel/react-measure/tar.gz/410e7d63a9612f54c4f0d2075d28b35f2a25d136"
6122+
react-measure@^2.1.2:
6123+
version "2.1.2"
6124+
resolved "https://registry.yarnpkg.com/react-measure/-/react-measure-2.1.2.tgz#2fa690cc657d1e7a1271902b7a5937e0055338d5"
61256125
dependencies:
61266126
get-node-dimensions "^1.2.0"
61276127
prop-types "^15.5.10"

0 commit comments

Comments
 (0)