Skip to content

Commit 65489fd

Browse files
[fix] Kafka listener (open-telemetry#2229)
* [fix] Kafka listener * fix protoc comments
1 parent 1cc1adf commit 65489fd

File tree

8 files changed

+10
-9
lines changed

8 files changed

+10
-9
lines changed

.env

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,8 @@ FLAGD_UI_DOCKERFILE=./src/flagd-ui/Dockerfile
142142

143143
# Kafka
144144
KAFKA_PORT=9092
145-
KAFKA_ADDR=kafka:${KAFKA_PORT}
145+
KAFKA_HOST=kafka
146+
KAFKA_ADDR=${KAFKA_HOST}:${KAFKA_PORT}
146147
KAFKA_DOCKERFILE=./src/kafka/Dockerfile
147148

148149
# Valkey

docker-compose.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,9 @@ services:
662662
memory: 620M
663663
restart: unless-stopped
664664
environment:
665-
- KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://kafka:9092
665+
- KAFKA_ADVERTISED_LISTENERS=PLAINTEXT://${KAFKA_HOST}:9092
666+
- KAFKA_LISTENERS=PLAINTEXT://${KAFKA_HOST}:9092,CONTROLLER://${KAFKA_HOST}:9093
667+
- KAFKA_CONTROLLER_QUORUM_VOTERS=1@${KAFKA_HOST}:9093
666668
- OTEL_EXPORTER_OTLP_ENDPOINT=http://${OTEL_COLLECTOR_HOST}:${OTEL_COLLECTOR_PORT_HTTP}
667669
- OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
668670
- OTEL_RESOURCE_ATTRIBUTES

src/checkout/genproto/oteldemo/demo.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/checkout/genproto/oteldemo/demo_grpc.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/frontend/protos/demo.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/kafka/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ USER appuser
1111

1212
ADD --chown=appuser:appuser https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v$OTEL_JAVA_AGENT_VERSION/opentelemetry-javaagent.jar /tmp/opentelemetry-javaagent.jar
1313

14-
ENV KAFKA_LISTENERS=PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
15-
ENV KAFKA_CONTROLLER_QUORUM_VOTERS='1@0.0.0.0:9093'
1614
ENV KAFKA_CONTROLLER_LISTENER_NAMES=CONTROLLER
1715
ENV KAFKA_LISTENER_SECURITY_PROTOCOL_MAP=CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT
1816
ENV KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS=0

src/product-catalog/genproto/oteldemo/demo.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/product-catalog/genproto/oteldemo/demo_grpc.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)