Fix setting names that are too long (#580)

Author: odow

src/MOI_wrapper/MOI_indicator_constraint.jl

@@ -183,12 +183,12 @@ function MOI.set(
     _update_if_necessary(model, check_attribute_change = false)
     info = _info(model, c)
     info.name = name
-    if !isempty(name)
+    if length(name) <= GRB_MAX_NAMELEN
         row = Cint(_info(model, c).row - 1)
         ret = GRBsetstrattrelement(model, "GenConstrName", row, name)
         _check_ret(model, ret)
+        _require_update(model, attribute_change = true)
     end
-    _require_update(model, attribute_change = true)
     return
 end
 

src/MOI_wrapper/MOI_wrapper.jl

@@ -1101,9 +1101,13 @@ function MOI.set(
 )
     info = _info(model, v)
     info.name = name
-    ret = GRBsetstrattrelement(model, "VarName", Cint(info.column) - 1, name)
-    _check_ret(model, ret)
-    _require_update(model, attribute_change = true)
+    if length(name) <= GRB_MAX_NAMELEN
+        # Gurobi has a maximum name limit of GRB_MAX_NAMELEN characters.
+        col = c_column(model, v)
+        ret = GRBsetstrattrelement(model, "VarName", col, name)
+        _check_ret(model, ret)
+        _require_update(model, attribute_change = true)
+    end
     model.name_to_variable = nothing
     return
 end
@@ -2256,9 +2260,10 @@ function MOI.set(
 )
     info = _info(model, c)
     info.name = name
-    if !isempty(name)
-        ret =
-            GRBsetstrattrelement(model, "ConstrName", Cint(info.row - 1), name)
+    if length(name) <= GRB_MAX_NAMELEN
+        # Gurobi has a maximum name limit of GRB_MAX_NAMELEN characters.
+        row = Cint(info.row - 1)
+        ret = GRBsetstrattrelement(model, "ConstrName", row, name)
         _check_ret(model, ret)
         _require_update(model, attribute_change = true)
     end
@@ -3348,8 +3353,12 @@ function MOI.get(model::Optimizer, ::MOI.Name)
     return unsafe_string(valueP[])
 end
 
-function MOI.set(model::Optimizer, ::MOI.Name, name::String)
+function MOI.set(model::Optimizer, attr::MOI.Name, name::String)
     ret = GRBsetstrattr(model, "ModelName", name)
+    if ret == GRB_ERROR_INVALID_ARGUMENT
+        msg = "Name too long (maximum name length is $GRB_MAX_NAMELEN characters)"
+        throw(MOI.SetAttributeNotAllowed(attr, msg))
+    end
     _check_ret(model, ret)
     _require_update(model, attribute_change = true)
     return
@@ -4444,21 +4453,13 @@ function MOI.set(
     name::String,
 )
     info = _info(model, c)
-    if !isempty(info.name) && model.name_to_constraint_index !== nothing
-        delete!(model.name_to_constraint_index, info.name)
-    end
-    _update_if_necessary(model)
-    ret = GRBsetstrattrelement(model, "QCName", Cint(info.row - 1), name)
-    _check_ret(model, ret)
-    _require_update(model, attribute_change = true)
     info.name = name
-    if model.name_to_constraint_index === nothing || isempty(name)
-        return
-    end
-    if haskey(model.name_to_constraint_index, name)
-        model.name_to_constraint_index = nothing
-    else
-        model.name_to_constraint_index[c] = name
+    _update_if_necessary(model)
+    if length(name) <= GRB_MAX_NAMELEN
+        ret = GRBsetstrattrelement(model, "QCName", Cint(info.row - 1), name)
+        _check_ret(model, ret)
+        _require_update(model; attribute_change = true)
     end
+    model.name_to_constraint_index = nothing
     return
 end

test/MOI/MOI_wrapper.jl

@@ -977,6 +977,45 @@ function test_primal_feasible_status()
     return
 end
 
+function test_ModelName_too_long()
+    model = Gurobi.Optimizer(GRB_ENV)
+    @test_throws(
+        MOI.SetAttributeNotAllowed{MOI.Name},
+        MOI.set(model, MOI.Name(), "a"^(GRB_MAX_NAMELEN + 1)),
+    )
+    name = "a"^GRB_MAX_NAMELEN
+    MOI.set(model, MOI.Name(), name)
+    @test MOI.get(model, MOI.Name()) == name
+    return
+end
+
+function test_VarName_too_long()
+    model = Gurobi.Optimizer(GRB_ENV)
+    x = MOI.add_variable(model)
+    name = "a"^256
+    MOI.set(model, MOI.VariableName(), x, name)
+    @test MOI.get(model, MOI.VariableName(), x) == name
+    MOI.set(model, MOI.VariableName(), x, "x")
+    @test MOI.get(model, MOI.VariableName(), x) == "x"
+    MOI.set(model, MOI.VariableName(), x, "")
+    @test MOI.get(model, MOI.VariableName(), x) == ""
+    return
+end
+
+function test_ConstrName_too_long()
+    model = Gurobi.Optimizer(GRB_ENV)
+    x = MOI.add_variable(model)
+    c = MOI.add_constraint(model, 1.0 * x, MOI.EqualTo(2.0))
+    name = "a"^256
+    MOI.set(model, MOI.ConstraintName(), c, name)
+    @test MOI.get(model, MOI.ConstraintName(), c) == name
+    MOI.set(model, MOI.ConstraintName(), c, "c")
+    @test MOI.get(model, MOI.ConstraintName(), c) == "c"
+    MOI.set(model, MOI.ConstraintName(), c, "")
+    @test MOI.get(model, MOI.ConstraintName(), c) == ""
+    return
+end
+
 end  # TestMOIWrapper
 
 TestMOIWrapper.runtests()