Merge pull request #19 from justindhillon/performance-improvements

Performance Improvements

Author: justindhillon

bin/scan/scanLinks.js

@@ -6,7 +6,7 @@ const help = require("../help.js");
 const fs = require('fs');
 
 // path is <file/directory path>
-async function links(path) {
+function links(path) {
   // Error: path does not exist
   if (!fs.existsSync(path)) {
     console.error('Error:', path, 'does not exist');
@@ -26,7 +26,7 @@ async function links(path) {
   const lastSlashIndex = removeSlash.lastIndexOf('/');
   const fluff = removeSlash.substring(0, lastSlashIndex + 1);
 
-  filePaths.forEach((filePath) => {
+  filePaths.forEach(async (filePath) => {
     // gets content of path
     const fileContent = readFile(filePath);
 
@@ -36,7 +36,7 @@ async function links(path) {
     // if any broken links are found, it writes 
     // them to an "output" folder
     if (links !== null) {
-      writeBrokenLinks(links, filePath, fluff);
+      await writeBrokenLinks(links, filePath, fluff);
     }
   });
 

bin/scan/writeBrokenLinks.js

@@ -11,7 +11,6 @@ function isLocalhostUrl(url) {
 // path is <file/directory path>
 // Writes data to identical path in "output"
 function writeToFile(data, PATH, fluff) {
-    console.log(fluff, PATH);
     PATH = PATH.replace(fluff, '');
     PATH = "output/" + PATH;
     const directoryPath = path.dirname(PATH);
@@ -38,18 +37,29 @@ function writeToFile(data, PATH, fluff) {
 // in an "output" folder
 async function writeBrokenLinks(links, PATH, fluff) {
     for (const link of links) {
-        await new Promise(r => setTimeout(r, 2000));
         if (isLocalhostUrl(link)) { continue }
-        linkCheck(link, function (err, result) {
-            if (err) {
-                console.error('Error: failed to validate', link);
-                process.exit(1);
-            }
+
+        try {
+            const result = await new Promise((resolve, reject) => {
+                linkCheck(link, function (err, result) {
+                    if (err) {
+                        reject(err);
+                    } else {
+                        resolve(result);
+                    }
+                });
+            });
+
             if (result.status === "dead") {
                 writeToFile(link, PATH, fluff);
             }
-        });
+        } catch (err) {
+            console.error('Error: failed to validate', link, err);
+            // Handle the error as needed, maybe continue to the next link instead of exiting
+        }
     }
+
+    return;
 };
 
 module.exports = writeBrokenLinks;

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "link-inspector",
-  "version": "1.0.5",
+  "version": "1.1.0",
   "description": "A npx package that automatically scans files and directories broken links.",
   "main": "index.js",
   "scripts": {