feat: introduce golangci-lint (#794)

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

Author: EItanya

.github/workflows/ci.yaml

@@ -214,3 +214,20 @@ jobs:
         run: make build-${{ matrix.image }}
         working-directory: ./
 
+  go-lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.24"
+          cache: true
+          cache-dependency-path: go/go.sum
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8
+        with:
+          version: v2.1
+          working-directory: go

go/.golangci.yaml

@@ -0,0 +1,11 @@
+version: "2"
+
+linters:
+  # Default set of linters.
+  # The value can be:
+  # - `standard`: https://golangci-lint.run/docs/linters/#enabled-by-default
+  # - `all`: enables all linters by default.
+  # - `none`: disables all linters by default.
+  # - `fast`: enables only linters considered as "fast" (`golangci-lint help linters --json | jq '[ .[] | select(.fast==true) ] | map(.name)'`).
+  # Default: standard
+  default: standard

go/Makefile

@@ -134,7 +134,7 @@ CONTROLLER_TOOLS_VERSION ?= v0.17.1
 ENVTEST_VERSION ?= $(shell go list -m -f "{{ .Version }}" sigs.k8s.io/controller-runtime | awk -F'[v.]' '{printf "release-%d.%d", $$2, $$3}')
 #ENVTEST_K8S_VERSION is the version of Kubernetes to use for setting up ENVTEST binaries (i.e. 1.31)
 ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}')
-GOLANGCI_LINT_VERSION ?= v1.63.4
+GOLANGCI_LINT_VERSION ?= v2.4.0
 
 .PHONY: controller-gen
 controller-gen: $(CONTROLLER_GEN) ## Download controller-gen locally if necessary.
@@ -157,7 +157,7 @@ $(ENVTEST): $(LOCALBIN)
 .PHONY: golangci-lint
 golangci-lint: $(GOLANGCI_LINT) ## Download golangci-lint locally if necessary.
 $(GOLANGCI_LINT): $(LOCALBIN)
-	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/cmd/golangci-lint,$(GOLANGCI_LINT_VERSION))
+	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/v2/cmd/golangci-lint,$(GOLANGCI_LINT_VERSION))
 
 # go-install-tool will 'go install' any package with custom target and name of binary, if it doesn't exist
 # $1 - target path with name of binary

go/cli/cmd/kagent/main.go

@@ -70,7 +70,7 @@ func main() {
 	invokeCmd.Flags().BoolVarP(&invokeCfg.Stream, "stream", "S", false, "Stream the response")
 	invokeCmd.Flags().StringVarP(&invokeCfg.File, "file", "f", "", "File to read the task from")
 	invokeCmd.Flags().StringVarP(&invokeCfg.URLOverride, "url-override", "u", "", "URL override")
-	invokeCmd.Flags().MarkHidden("url-override")
+	invokeCmd.Flags().MarkHidden("url-override") //nolint:errcheck
 
 	bugReportCmd := &cobra.Command{
 		Use:   "bug-report",
@@ -123,7 +123,7 @@ func main() {
 		Long:  `Get a kagent resource`,
 		Run: func(cmd *cobra.Command, args []string) {
 			fmt.Fprintf(os.Stderr, "No resource type provided\n\n")
-			cmd.Help()
+			cmd.Help() //nolint:errcheck
 			os.Exit(1)
 		},
 	}

go/cli/internal/cli/const_test.go

@@ -62,10 +62,10 @@ func TestGetModelProvider(t *testing.T) {
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
 			if tc.envVarValue == "" {
-				os.Unsetenv(KAGENT_DEFAULT_MODEL_PROVIDER)
+				os.Unsetenv(KAGENT_DEFAULT_MODEL_PROVIDER) //nolint:errcheck
 			} else {
-				os.Setenv(KAGENT_DEFAULT_MODEL_PROVIDER, tc.expectedHelmKey)
-				defer os.Unsetenv(KAGENT_DEFAULT_MODEL_PROVIDER)
+				os.Setenv(KAGENT_DEFAULT_MODEL_PROVIDER, tc.expectedHelmKey) //nolint:errcheck
+				defer os.Unsetenv(KAGENT_DEFAULT_MODEL_PROVIDER)             //nolint:errcheck
 			}
 
 			result := GetModelProvider()

go/cli/internal/cli/get.go

@@ -41,7 +41,7 @@ func GetAgentCmd(cfg *config.Config, resourceName string) {
 			return
 		}
 		byt, _ := json.MarshalIndent(agent, "", "  ")
-		fmt.Fprintln(os.Stdout, string(byt))
+		fmt.Fprintln(os.Stdout, string(byt)) //nolint:errcheck
 	}
 }
 
@@ -70,7 +70,7 @@ func GetSessionCmd(cfg *config.Config, resourceName string) {
 			return
 		}
 		byt, _ := json.MarshalIndent(session, "", "  ")
-		fmt.Fprintln(os.Stdout, string(byt))
+		fmt.Fprintln(os.Stdout, string(byt)) //nolint:errcheck
 	}
 }
 

go/cli/internal/cli/install.go

@@ -79,9 +79,7 @@ func InstallCmd(ctx context.Context, cfg *config.Config) *PortForward {
 
 	// split helmExtraArgs by "--set" to get additional values
 	extraValues := strings.Split(helmExtraArgs, "--set")
-	for _, hev := range extraValues {
-		values = append(values, hev)
-	}
+	values = append(values, extraValues...)
 
 	// spinner for installation progress
 	s := spinner.New(spinner.CharSets[35], 100*time.Millisecond)
@@ -119,7 +117,7 @@ func InstallCmd(ctx context.Context, cfg *config.Config) *PortForward {
 
 	// Stop the spinner completely before printing the success message
 	s.Stop()
-	fmt.Fprintln(os.Stdout, "kagent installed successfully")
+	fmt.Fprintln(os.Stdout, "kagent installed successfully") //nolint:errcheck
 
 	pf, err := NewPortForward(ctx, cfg)
 	if err != nil {
@@ -146,11 +144,11 @@ func deleteCRDs(ctx context.Context) error {
 		if out, err := deleteCmd.CombinedOutput(); err != nil {
 			if !strings.Contains(string(out), "not found") {
 				errMsg := fmt.Sprintf("Error deleting CRD %s: %s", crd, string(out))
-				fmt.Fprintln(os.Stderr, errMsg)
+				fmt.Fprintln(os.Stderr, errMsg) //nolint:errcheck
 				deleteErrors = append(deleteErrors, errMsg)
 			}
 		} else {
-			fmt.Fprintf(os.Stdout, "Successfully deleted CRD %s\n", crd)
+			fmt.Fprintf(os.Stdout, "Successfully deleted CRD %s\n", crd) //nolint:errcheck
 		}
 	}
 
@@ -216,5 +214,5 @@ func UninstallCmd(ctx context.Context, cfg *config.Config) {
 	}
 
 	s.Stop()
-	fmt.Fprintln(os.Stdout, "\nkagent uninstalled successfully")
+	fmt.Fprintln(os.Stdout, "\nkagent uninstalled successfully") //nolint:errcheck
 }

go/cli/internal/cli/invoke.go

@@ -134,6 +134,6 @@ func InvokeCmd(ctx context.Context, cfg *InvokeCfg) {
 			return
 		}
 
-		fmt.Fprintf(os.Stdout, "%+v\n", string(jsn))
+		fmt.Fprintf(os.Stdout, "%+v\n", string(jsn)) //nolint:errcheck
 	}
 }

go/cli/internal/cli/utils.go

@@ -13,7 +13,7 @@ import (
 )
 
 var (
-	ErrServerConnection = fmt.Errorf("Error connecting to server. Please run 'install' command first.")
+	ErrServerConnection = fmt.Errorf("error connecting to server. Please run 'install' command first")
 )
 
 func CheckServerConnection(client *client.ClientSet) error {
@@ -70,7 +70,7 @@ func (p *PortForward) Stop() {
 	p.cancel()
 	// This will terminate the kubectl process in case the cancel does not work.
 	if p.cmd.Process != nil {
-		p.cmd.Process.Kill()
+		p.cmd.Process.Kill() //nolint:errcheck
 	}
 
 	// Don't wait for the process - just cancel the context and let it die
@@ -85,15 +85,15 @@ func StreamA2AEvents(ch <-chan protocol.StreamingMessageEvent, verbose bool) {
 				fmt.Fprintf(os.Stderr, "Error marshaling A2A event: %v\n", err)
 				continue
 			}
-			fmt.Fprintf(os.Stdout, "%+v\n", string(json))
+			fmt.Fprintf(os.Stdout, "%+v\n", string(json)) //nolint:errcheck
 		} else {
 			json, err := event.MarshalJSON()
 			if err != nil {
 				fmt.Fprintf(os.Stderr, "Error marshaling A2A event: %v\n", err)
 				continue
 			}
-			fmt.Fprintf(os.Stdout, "%+v\n", string(json))
+			fmt.Fprintf(os.Stdout, "%+v\n", string(json)) //nolint:errcheck
 		}
 	}
-	fmt.Fprintln(os.Stdout) // Add a newline after streaming is complete
+	fmt.Fprintln(os.Stdout) //nolint:errcheck // Add a newline after streaming is complete
 }

go/cli/internal/cli/version.go

@@ -28,5 +28,5 @@ func VersionCmd(cfg *config.Config) {
 		versionInfo["backend_version"] = version.KAgentVersion
 	}
 
-	json.NewEncoder(os.Stdout).Encode(versionInfo)
+	json.NewEncoder(os.Stdout).Encode(versionInfo) //nolint:errcheck
 }