Request IPs?

[BobbyWibowo]

Hyper-Express was started with

const safe = new HyperExpress.Server({
  trust_proxy: true
})

Yet, here's what I'm getting in Response:

req.headers: {
  connection: 'upgrade',
  host: 'safe.fiery.me',
  'x-real-ip': '180.x.x.x',
  'x-forwarded-for': '180.x.x.x, 162.158.163.156',
  'x-forwarded-proto': 'https',
  ...
}
req.ip: '127.0.0.1'
req.proxy_ip: ''

In x-forwarded-for is my IP, then followed by Cloudflare IP

It's running behind Nginx and Cloudflare, for context

[kartikk221]

Could you clarify how the behavior of the trust_proxy parameter is incorrect or unintended?
The trust_proxy parameter is internally used in ExpressJS compatibility properties like Response.protocol, Response.ips, Response.hostname.

[kartikk221]

I see, so essentially when trust_proxy is true then the Response.ip property automatically returns the first IP in the X-Forwarded-For chain?

[BobbyWibowo]

At least that's the case in ExpressJS, yes

[kartikk221]

I've pushed a commit that will return the first IP address from the "x-forwarded-for" header set of IPs if trust_proxy is enabled here: 23f0ad9 If this properly matches the ExpressJS behavior then I'll go ahead and have it pushed in in the next update.

[BobbyWibowo]

Thanks, I will confirm tomorrow (I live on the other side of the planet)

[BobbyWibowo]

Hi there, just want to inform that 6.2.6 is behaving as expected now, thank you!