Skip to content

Commit 7deee05

Browse files
authored
Merge pull request #188 from kit-data-manager/development
PR for v1.5.3
2 parents 0a7013c + 60b23c6 commit 7deee05

File tree

5 files changed

+19
-25
lines changed

5 files changed

+19
-25
lines changed

CHANGELOG.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## [Unreleased]
9+
Added
10+
911
Changed
1012

1113
Fixed
1214

1315
Security
1416

17+
## [1.5.3] - 2023-12-17
18+
Fixed
19+
* Added data folder creation to Docker build as workaround
20+
1521
## [1.5.2] - 2023-12-15
1622
Fixed
1723
* Fixed Docker build
@@ -206,7 +212,8 @@ Added
206212

207213
- First public version
208214

209-
[Unreleased]: https://github.com/kit-data-manager/base-repo/compare/v1.5.2...HEAD
215+
[Unreleased]: https://github.com/kit-data-manager/base-repo/compare/v1.5.3...HEAD
216+
[1.5.3]: https://github.com/kit-data-manager/base-repo/compare/v1.5.2...v1.5.3
210217
[1.5.2]: https://github.com/kit-data-manager/base-repo/compare/v1.5.1...v1.5.2
211218
[1.5.1]: https://github.com/kit-data-manager/base-repo/compare/v1.5.0...v1.5.1
212219
[1.5.0]: https://github.com/kit-data-manager/base-repo/compare/v1.4.0...v1.5.0

config/application-docker.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ repo.search.index:baserepo
5151
# Workaround for a potential issue with spring cloud 4.1.0 that broke the elastic search proxy
5252
spring.cloud.gateway.proxy.sensitive=content-length
5353

54-
repo.basepath: file:///var/repository/
54+
repo.basepath:file:///var/repository/
5555
repo.plugin.storage.date.pathPattern: @{year}/@{month}/@{day}
5656
repo.plugin.versioning: simple
5757
repo.plugin.storage: dateBased

src/main/java/edu/kit/datamanager/repo/Application.java

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder;
6060
import org.springframework.scheduling.annotation.EnableScheduling;
6161
import org.springframework.boot.context.properties.ConfigurationProperties;
62+
import org.springframework.boot.context.properties.EnableConfigurationProperties;
6263
import org.springframework.context.annotation.Bean;
6364
import org.springframework.data.elasticsearch.repository.config.EnableElasticsearchRepositories;
6465

@@ -71,6 +72,7 @@
7172
@ComponentScan({"edu.kit.datamanager"})
7273
@EnableElasticsearchRepositories(basePackages = "edu.kit.datamanager.repo.elastic")
7374
@EntityScan("edu.kit.datamanager") // if you have it
75+
//@EnableConfigurationProperties(ApplicationProperties.class)
7476
public class Application {
7577

7678
private static final Logger LOG = LoggerFactory.getLogger(Application.class);
@@ -79,29 +81,11 @@ public class Application {
7981
@Autowired
8082
private ApplicationEventPublisher eventPublisher;
8183

82-
//private ApplicationProperties applicationProperties;
8384
@Autowired
8485
private IRepoVersioningService[] versioningServices;
8586
@Autowired
8687
private IRepoStorageService[] storageServices;
8788

88-
// @Autowired
89-
// private IDataResourceDao dataResourceDao;
90-
// @Autowired
91-
// private ApplicationProperties applicationProperties;
92-
93-
/* @Autowired
94-
private IDataResourceService dataResourceService;
95-
@Autowired
96-
private IContentInformationService contentInformationService;*/
97-
// @Autowired
98-
// private RequestMappingHandlerAdapter requestMappingHandlerAdapter;
99-
// @Bean
100-
// @Scope("prototype")
101-
// public Logger logger(InjectionPoint injectionPoint) {
102-
// Class<?> targetClass = injectionPoint.getMember().getDeclaringClass();
103-
// return LoggerFactory.getLogger(targetClass.getCanonicalName());
104-
// }
10589
@Bean
10690
public IDataResourceService dataResourceService() {
10791
return new DataResourceService();
@@ -145,9 +129,8 @@ public void onRefresh(RefreshScopeRefreshedEvent event) {
145129
// }
146130

147131
@Bean
148-
@ConfigurationProperties("repo")
149132
public ApplicationProperties applicationProperties() {
150-
return new ApplicationProperties();
133+
return new ApplicationProperties();
151134
}
152135

153136
@Bean

src/main/java/edu/kit/datamanager/repo/configuration/ApplicationProperties.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616
package edu.kit.datamanager.repo.configuration;
1717

1818
import edu.kit.datamanager.configuration.GenericApplicationProperties;
19+
import jakarta.validation.Valid;
1920
import java.net.URL;
2021
import lombok.Data;
2122
import lombok.EqualsAndHashCode;
2223
import org.springframework.beans.factory.annotation.Value;
24+
import org.springframework.boot.context.properties.ConfigurationProperties;
2325
import org.springframework.cloud.context.config.annotation.RefreshScope;
2426
import org.springframework.stereotype.Component;
2527
import org.springframework.validation.annotation.Validated;
@@ -33,6 +35,7 @@
3335
@Validated
3436
@RefreshScope
3537
@EqualsAndHashCode(callSuper = true)
38+
@ConfigurationProperties("repo")
3639
public class ApplicationProperties extends GenericApplicationProperties {
3740

3841
@edu.kit.datamanager.annotations.LocalFolderURL
@@ -54,4 +57,4 @@ public class ApplicationProperties extends GenericApplicationProperties {
5457
private boolean enableCsrf;
5558
@Value("${repo.security.allowedOriginPattern:http://localhost:*}")
5659
private String allowedOriginPattern;
57-
}
60+
}

src/main/java/edu/kit/datamanager/repo/web/impl/DataResourceAuditController.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ public class DataResourceAuditController implements IDataResourceAuditController
5757
private Logger LOGGER = LoggerFactory.getLogger(DataResourceController.class);
5858

5959
private final IContentInformationService contentInformationService;
60-
@Autowired
61-
private ApplicationProperties applicationProperties;
60+
61+
private final ApplicationProperties applicationProperties;
6262

6363
private final IAuditService<DataResource> auditService;
6464
private final IAuditService<ContentInformation> contentAuditService;
@@ -70,6 +70,7 @@ public class DataResourceAuditController implements IDataResourceAuditController
7070
* @param applicationProperties The application properties.
7171
* @param repositoryConfig The repository config.
7272
*/
73+
@Autowired
7374
public DataResourceAuditController(ApplicationProperties applicationProperties,
7475
RepoBaseConfiguration repositoryConfig
7576
) {

0 commit comments

Comments
 (0)