Invalidate a required checkbox group on form init if it has no default checked values (#184)

Author: kjac

Source/Umbraco/JS/FormEditor/FormEditorAsync.js

@@ -53,7 +53,7 @@
       }
       $scope.formData[fieldName] = values;
       if (required) {
-        $scope.getFormPage(pageNumber)[fieldName].$setValidity("required", values != undefined && values.length != 0);
+        $scope.setMultiSelectValidity(fieldName, pageNumber, values != undefined && values.length != 0);
       }
     };
 
@@ -62,6 +62,10 @@
       return values.indexOf(value) >= 0;
     };
 
+    $scope.setMultiSelectValidity = function (fieldName, pageNumber, valid) {
+      $scope.getFormPage(pageNumber)[fieldName].$setValidity("required", valid);
+    }
+
     // this exposes the form validation to a global scope
     $scope.globalValidateForm = function () {
       var deferred = $q.defer();

Source/Umbraco/Views/Partials/FormEditor/FieldsAsync/core.checkboxgroup.cshtml

@@ -1,11 +1,12 @@
+@using FormEditor.Rendering
 @inherits Umbraco.Web.Mvc.UmbracoViewPage<FormEditor.Fields.CheckboxGroupField>
 <div class="form-group @(Model.Mandatory ? "required" : null) @(Model.Invalid ? "has-error" : null)" name="@Model.FormSafeName" ng-model="@Model.FormSafeName" action-field="@Model.FormSafeName">
   <label>@Model.Label</label>
   @foreach(var fieldValue in Model.FieldValues)
   {
     <div class="checkbox">
       <label>
-        <input type="checkbox" ng-checked="hasMultiSelectValue('@Model.FormSafeName', '@HttpUtility.JavaScriptStringEncode(fieldValue.Value)')" ng-click="toggleMultiSelectValue('@Model.FormSafeName', @ViewBag.FormEditorPageNumber, '@fieldValue.Value', @Model.Mandatory.ToString().ToLowerInvariant())" />
+        <input type="checkbox" ng-checked="hasMultiSelectValue('@Model.FormSafeName', '@HttpUtility.JavaScriptStringEncode(fieldValue.Value)')" ng-click="toggleMultiSelectValue('@Model.FormSafeName', @ViewBag.FormEditorPageNumber, '@fieldValue.Value', @Model.Mandatory.ToString().ToLowerInvariant())" ng-init="@(Model.Mandatory && fieldValue == Model.FieldValues.First() && Model.HasDefaultValue() == false ? string.Format("setMultiSelectValidity('{0}', {1}, false)", Model.FormSafeName, ViewBag.FormEditorPageNumber) : null)"/>
         @fieldValue.Value
       </label>
     </div>