Skip to content

Commit 76944f4

Browse files
committed
Fix linux install checks
Env variables are in the wrong place, node20 issue
1 parent 4893428 commit 76944f4

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

.github/workflows/build.yml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
- 3306:3306
9191

9292
steps:
93-
- uses: actions/checkout@v3
93+
- uses: actions/checkout@v4
9494
with:
9595
submodules: recursive
9696

@@ -99,7 +99,7 @@ jobs:
9999
#
100100

101101
- name: "setup: cmake & ninja"
102-
uses: lukka/get-cmake@v3.25.2 # workaround for node 20 issue
102+
uses: lukka/get-cmake@latest
103103
with:
104104
cmakeVersion: "${{ env.CMAKE_VERSION }}"
105105

@@ -319,15 +319,15 @@ jobs:
319319
PATH: "/opt/python/cp311-cp311/bin:/opt/rh/devtoolset-10/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/github/home/.cargo/bin:/opt/mssql-tools/bin"
320320

321321
steps:
322-
- uses: actions/checkout@v3
322+
- uses: actions/checkout@v4
323323
with:
324324
submodules: recursive
325325

326326
#
327327
# setup
328328
#
329329
- name: "setup: cmake & ninja"
330-
uses: lukka/get-cmake@v3.25.2 # workaround for node 20 issue
330+
uses: lukka/get-cmake@latest
331331
with:
332332
cmakeVersion: "${{ env.CMAKE_VERSION }}"
333333

@@ -545,15 +545,17 @@ jobs:
545545
name: "Install-check: ${{ matrix.os.label }}/${{ matrix.arch.label }}"
546546
continue-on-error: ${{ !!matrix.os.xfail }}
547547

548+
env:
549+
ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
550+
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
551+
548552
container:
549553
image: ${{ matrix.os.image }}
550554
credentials:
551555
username: ${{ needs.amazon-ecr-auth.outputs.docker_username }}
552556
password: ${{ needs.amazon-ecr-auth.outputs.docker_password }}
553557
env:
554558
DEBIAN_FRONTEND: noninteractive
555-
ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION: node16
556-
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
557559

558560
steps:
559561
- name: setup
@@ -608,7 +610,7 @@ jobs:
608610
command -v kart
609611
kart --version
610612
611-
- uses: actions/checkout@v3
613+
- uses: actions/checkout@v4
612614

613615
- name: e2e test (no helper)
614616
env:
@@ -647,7 +649,7 @@ jobs:
647649
PY_VER_ID: "cp311-cp311"
648650

649651
steps:
650-
- uses: actions/checkout@v3
652+
- uses: actions/checkout@v4
651653
with:
652654
submodules: recursive
653655

@@ -663,7 +665,7 @@ jobs:
663665
cache-dependency-path: 'requirements/*.txt'
664666

665667
- name: "setup: cmake & ninja"
666-
uses: lukka/get-cmake@v3.25.2 # workaround for node 20 issue
668+
uses: lukka/get-cmake@latest
667669
with:
668670
cmakeVersion: "${{ env.CMAKE_VERSION }}"
669671

@@ -784,7 +786,7 @@ jobs:
784786
PY_VER_INSTALLER: "https://www.python.org/ftp/python/3.11.6/python-3.11.6-macos11.pkg"
785787

786788
steps:
787-
- uses: actions/checkout@v3
789+
- uses: actions/checkout@v4
788790
with:
789791
submodules: recursive
790792

@@ -1042,7 +1044,7 @@ jobs:
10421044
)
10431045
10441046
steps:
1045-
- uses: actions/checkout@v3
1047+
- uses: actions/checkout@v4
10461048
with:
10471049
submodules: recursive
10481050

0 commit comments

Comments
 (0)