Skip to content

Commit 127a1af

Browse files
author
Mengqi Yu
authored
always run check licenses with other tests (#158)
1 parent fb9e5d7 commit 127a1af

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

functions/go/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ endif
8383

8484
# Recipes for individual function
8585
.PHONY: func-fix func-vet func-fmt func-test func-lint \
86-
func-build func-push func-verify
87-
func-verify: func-fix func-vet func-fmt func-test func-lint
86+
func-build func-push func-verify func-check-licenses
87+
func-verify: func-fix func-vet func-fmt func-test func-lint func-check-licenses
8888

8989
func-fix:
9090
cd $(CURRENT_FUNCTION) && go fix ./...
@@ -103,7 +103,7 @@ func-test:
103103
func-vet:
104104
cd $(CURRENT_FUNCTION) && go vet ./...
105105

106-
func-check-licenses:
106+
func-check-licenses: install-go-licenses
107107
@echo Checking licenses for $(CURRENT_FUNCTION)...
108108
cd $(CURRENT_FUNCTION) && $(GO_LICENSES) check .
109109

functions/ts/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ CONTRIB_GCR = gcr.io/kpt-fn-contrib
2121
help: ## Print this help
2222
@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
2323

24-
.PHONY: test build npm-ci push
24+
.PHONY: test build npm-ci push check-licenses
2525

2626
# Edit this list to contain all of the curated ts functions
2727
CURATED_FUNCTIONS := \
@@ -95,10 +95,10 @@ $(FUNCTION_CHECKLICENSES):
9595
func-npm-ci:
9696
cd $(CURRENT_FUNCTION) && npm ci
9797

98-
func-test: func-npm-ci
98+
func-test: func-npm-ci func-check-licenses
9999
cd $(CURRENT_FUNCTION) && npm test
100100

101-
func-check-licenses: func-npm-ci
101+
func-check-licenses:
102102
cd $(CURRENT_FUNCTION) && npm run check-licenses
103103

104104
func-build: func-test

0 commit comments

Comments
 (0)