module's Init function shouldn't be called before api is ready (#268)

jlowellwofford · jlowellwofford · commit f3a770de5f1c · 2021-05-17T08:15:41.000-06:00
diff --git a/core/ServiceInstance.go b/core/ServiceInstance.go
@@ -172,7 +172,6 @@ func ModuleExecute(id, module, sock string) {
 	fmt.Printf("I am: %s\n", id)
 
 	api := NewModuleAPIClient(sock)
-	mss.Init(api)
 	// call in, and get a control chan
 	cc, e := api.ServiceInit(id, module)
 	if e != nil {
@@ -242,6 +241,7 @@ func ModuleExecute(id, module, sock string) {
 		mc.UpdateConfig(defaults)
 	}
 
+	mss.Init(api)
 	if config {
 		updateConfig()
 	}

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,6 @@ func ModuleExecute(id, module, sock string) {`
`172`	`172`	`fmt.Printf("I am: %s\n", id)`
`173`	`173`
`174`	`174`	`api := NewModuleAPIClient(sock)`
`175`		`- mss.Init(api)`
`176`	`175`	`// call in, and get a control chan`
`177`	`176`	`cc, e := api.ServiceInit(id, module)`
`178`	`177`	`if e != nil {`
`@@ -242,6 +241,7 @@ func ModuleExecute(id, module, sock string) {`
`242`	`241`	`mc.UpdateConfig(defaults)`
`243`	`242`	`}`
`244`	`243`
	`244`	`+ mss.Init(api)`
`245`	`245`	`if config {`
`246`	`246`	`updateConfig()`
`247`	`247`	`}`