Skip to content

Commit 922943a

Browse files
authored
Merge pull request #1 from jjtbsomhorst/small-refactors
♻️ Small refactors
2 parents b0eb83c + 31093cf commit 922943a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ composer require labrodev/haversine
2323
use Labrodev\Haversine\Calculator;
2424

2525
// Distance in kilometers between Paris and Frankfurt
26-
$distance = Calculator::fetchHaversineDistance(48.8566, 2.3522, 50.1109, 8.6821);
26+
$distance = Calculator::haversineDistance(48.8566, 2.3522, 50.1109, 8.6821);
2727

2828
echo $distance; // e.g., 478.5
2929
```

src/Calculator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
*
1515
* @package Labrodev\Haversine
1616
*/
17-
class Calculator
17+
final class Calculator
1818
{
1919
public const EARTH_RADIUS = 6371; // Radius in kilometers
2020

@@ -27,7 +27,7 @@ class Calculator
2727
* @param float $lon2 Longitude of point B
2828
* @return float Distance in kilometers
2929
*/
30-
public static function fetchHaversineDistance(float $lat1, float $lon1, float $lat2, float $lon2): float
30+
public static function haversineDistance(float $lat1, float $lon1, float $lat2, float $lon2): float
3131
{
3232
$r = self::EARTH_RADIUS;
3333

tests/CalculatorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public function test_fetch_haversine_distance(
1616
float $expected,
1717
float $delta = 0.1
1818
): void {
19-
$distance = Calculator::fetchHaversineDistance($lat1, $lon1, $lat2, $lon2);
19+
$distance = Calculator::haversineDistance($lat1, $lon1, $lat2, $lon2);
2020
$this->assertEqualsWithDelta($expected, $distance, $delta);
2121
}
2222

0 commit comments

Comments
 (0)