refactor(l2): remove redb and libmdbx from rollup store (#4063)

**Motivation**

We are not using `libmdbx` and `redb` for the rollup store and
maintaining them is a waste of time.

**Description**

Removes `libmdbx` and `redb` from the rollup store.

Closes #3743

Author: avilagaston9

Cargo.lock

@@ -11,7 +11,7 @@ build: ## 🔨 Build the client
 lint: ## 🧹 Linter check
 	# Note that we are compiling without the "gpu" feature (see #4048 for why)
 	# To compile with it you can replace '-F' with '--all-features', but you need to have nvcc installed
-	cargo clippy --all-targets -F debug,redb,risc0,rollup_storage_libmdbx,rollup_storage_redb,sp1,sync-test \
+	cargo clippy --all-targets -F debug,redb,risc0,sp1,sync-test \
 		--workspace --exclude ethrex-replay --exclude ethrex-prover --exclude zkvm_interface --exclude ef_tests-blockchain \
 		--release -- -D warnings
 

Makefile

@@ -70,11 +70,9 @@ c-kzg = [
   "ethrex-p2p/c-kzg",
 ]
 metrics = ["ethrex-blockchain/metrics", "ethrex-l2/metrics"]
-libmdbx = ["ethrex-storage/libmdbx", "ethrex-storage-rollup/libmdbx"]
+libmdbx = ["ethrex-storage/libmdbx"]
 redb = ["dep:redb", "ethrex-storage/redb"]
 blst = ["ethrex-vm/blst"]
-rollup_storage_libmdbx = ["ethrex-storage-rollup/libmdbx"]
-rollup_storage_redb = ["ethrex-storage-rollup/redb"]
 rollup_storage_sql = ["ethrex-storage-rollup/sql"]
 sync-test = ["ethrex-p2p/sync-test"]
 sp1 = ["ethrex-prover/sp1"]

cmd/ethrex/Cargo.toml

@@ -291,12 +291,10 @@ impl Command {
                     }
                 };
                 cfg_if::cfg_if! {
-                    if #[cfg(feature = "rollup_storage_libmdbx")] {
-                        let rollup_store_type = ethrex_storage_rollup::EngineTypeRollup::Libmdbx;
-                    } else if #[cfg(feature = "rollup_storage_sql")] {
+                    if #[cfg(feature = "rollup_storage_sql")] {
                         let rollup_store_type = ethrex_storage_rollup::EngineTypeRollup::SQL;
                     } else {
-                        eyre::bail!("Expected one of libmdbx or sql rollup store engine");
+                        eyre::bail!("Expected sql rollup store engine");
                     }
                 };
 

cmd/ethrex/l2/command.rs

@@ -101,11 +101,8 @@ pub async fn init_rollup_store(data_dir: &str) -> StoreRollup {
     cfg_if::cfg_if! {
         if #[cfg(feature = "rollup_storage_sql")] {
             let engine_type = EngineTypeRollup::SQL;
-        } else if #[cfg(feature = "rollup_storage_redb")] {
-            let engine_type = EngineTypeRollup::RedB;
-        } else if #[cfg(feature = "rollup_storage_libmdbx")] {
-            let engine_type = EngineTypeRollup::Libmdbx;
-        } else {
+        }
+        else {
             let engine_type = EngineTypeRollup::InMemory;
         }
     }

cmd/ethrex/l2/initializers.rs

@@ -35,8 +35,8 @@ CI_ETHREX_WORKDIR := /usr/local/bin
 L1_RPC_URL=http://localhost:8545
 L1_PRIVATE_KEY=0x385c546456b6a603a1cfcaa9ec9494ba4832da08dd6bcf4de9a71e4a01b74924
 
-ethrex_L2_DEV_LIBMDBX?=dev_ethrex_l2
-ethrex_L1_DEV_LIBMDBX=dev_ethrex_l1
+ethrex_L2_DEV_DB?=dev_ethrex_l2
+ethrex_L1_DEV_DB=dev_ethrex_l1
 L1_PORT=8545
 L2_PORT=1729
 L1_AUTH_PORT=8551
@@ -71,10 +71,10 @@ init-l1: ## 🚀 Initializes an L1 Lambda ethrex Client
 	--http.addr ${L1_RPC_ADDRESS} \
 	--authrpc.port ${L1_AUTH_PORT} \
 	--dev \
-	--datadir ${ethrex_L1_DEV_LIBMDBX}
+	--datadir ${ethrex_L1_DEV_DB}
 
 rm-db-l1: ## 🛑 Removes the DB used by the L1
-	cargo run --release --manifest-path ../../Cargo.toml --bin ethrex -- removedb --datadir ${ethrex_L1_DEV_LIBMDBX} --force
+	cargo run --release --manifest-path ../../Cargo.toml --bin ethrex -- removedb --datadir ${ethrex_L1_DEV_DB} --force
 
 deploy-l1: ## 📜 Deploys the L1 contracts
 	COMPILE_CONTRACTS=true \
@@ -124,7 +124,7 @@ init-l2: ## 🚀 Initializes an L2 Lambda ethrex Client
 	--metrics \
 	--metrics.port ${L2_PROMETHEUS_METRICS_PORT} \
 	--evm levm \
-	--datadir ${ethrex_L2_DEV_LIBMDBX} \
+	--datadir ${ethrex_L2_DEV_DB} \
 	--l1.bridge-address ${DEFAULT_BRIDGE_ADDRESS} \
 	--l1.on-chain-proposer-address ${DEFAULT_ON_CHAIN_PROPOSER_ADDRESS} \
 	--eth.rpc-url ${L1_RPC_URL} \
@@ -150,7 +150,7 @@ down-l2: ## 🛑 Shuts down the L2 Lambda ethrex Client
 	pkill -x ethrex || exit 0
 
 rm-db-l2: ## 🛑 Removes the DB used by the L2
-	cargo run --release --manifest-path ../../Cargo.toml --bin ethrex -- l2 removedb --datadir ${ethrex_L2_DEV_LIBMDBX} --force
+	cargo run --release --manifest-path ../../Cargo.toml --bin ethrex -- l2 removedb --datadir ${ethrex_L2_DEV_DB} --force
 
 restart-l2: down-l2 rm-db-l2 init-l2 ## 🔄 Restarts the L2 Lambda ethrex Client
 

crates/l2/Makefile

@@ -17,8 +17,6 @@ futures.workspace = true
 anyhow = "1.0.86"
 thiserror.workspace = true
 tracing.workspace = true
-libmdbx = { workspace = true, optional = true }
-redb = { workspace = true, optional = true }
 libsql = { workspace = true, optional = true }
 # NOTE: intentionally avoiding the workspace dep as it brings "full" features, breaking the provers
 # We only need the runtime for the blocking databases to spawn blocking tasks
@@ -29,8 +27,6 @@ bincode = "1.3.3"
 
 [features]
 default = []
-libmdbx = ["dep:libmdbx", "dep:tokio"]
-redb = ["dep:redb", "dep:tokio"]
 sql = ["dep:libsql", "dep:tokio"]
 l2 = []
 

crates/l2/storage/Cargo.toml

@@ -1,33 +1,10 @@
-#[cfg(feature = "redb")]
-use redb::{CommitError, DatabaseError, StorageError, TableError, TransactionError};
 use thiserror::Error;
 
 // TODO improve errors
 #[derive(Debug, Error)]
 pub enum RollupStoreError {
     #[error("DecodeError")]
     DecodeError,
-    #[cfg(feature = "libmdbx")]
-    #[error("Libmdbx error: {0}")]
-    LibmdbxError(anyhow::Error),
-    #[cfg(feature = "redb")]
-    #[error("Redb Storage error: {0}")]
-    RedbStorageError(#[from] StorageError),
-    #[cfg(feature = "redb")]
-    #[error("Redb Table error: {0}")]
-    RedbTableError(#[from] TableError),
-    #[cfg(feature = "redb")]
-    #[error("Redb Commit error: {0}")]
-    RedbCommitError(#[from] CommitError),
-    #[cfg(feature = "redb")]
-    #[error("Redb Transaction error: {0}")]
-    RedbTransactionError(#[from] Box<TransactionError>),
-    #[error("Redb Database error: {0}")]
-    #[cfg(feature = "redb")]
-    RedbDatabaseError(#[from] DatabaseError),
-    #[error("Redb Cast error")]
-    #[cfg(feature = "redb")]
-    RedbCastError,
     #[cfg(feature = "sql")]
     #[error("Limbo Query error: {0}")]
     SQLQueryError(#[from] libsql::Error),

crates/l2/storage/src/error.rs

@@ -1,6 +1,5 @@
 mod api;
 mod error;
-mod rlp;
 mod store;
 mod store_db;