Skip to content

Commit c04d319

Browse files
committed
tests: fix {de,en}coding tests
1 parent b52fde2 commit c04d319

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

crates/networking/p2p/rlpx/eth/blocks.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use crate::rlpx::{message::RLPxMessage, utils::snappy_encode};
1313

1414
pub const HASH_FIRST_BYTE_DECODER: u8 = 160;
1515

16-
#[derive(Debug, PartialEq, Eq)]
16+
#[derive(Debug, PartialEq, Eq, Clone)]
1717
pub enum HashOrNumber {
1818
Hash(BlockHash),
1919
Number(BlockNumber),
@@ -112,12 +112,12 @@ impl GetBlockHeaders {
112112
impl RLPxMessage for GetBlockHeaders {
113113
fn encode(&self, buf: &mut dyn BufMut) -> Result<(), RLPEncodeError> {
114114
let mut encoded_data = vec![];
115+
let limit = self.limit;
116+
let skip = self.skip;
117+
let reverse = self.reverse as u8;
115118
Encoder::new(&mut encoded_data)
116119
.encode_field(&self.id)
117-
.encode_field(&self.startblock)
118-
.encode_field(&self.limit)
119-
.encode_field(&self.skip)
120-
.encode_field(&self.reverse)
120+
.encode_field(&(self.startblock.clone(), limit, skip, reverse))
121121
.finish();
122122
let msg_data = snappy_encode(encoded_data)?;
123123
buf.put_slice(&msg_data);
@@ -158,7 +158,6 @@ impl RLPxMessage for BlockHeaders {
158158
// Each message is encoded with its own
159159
// message identifier (code).
160160
// Go ethereum reference: https://github.com/ethereum/go-ethereum/blob/20bf543a64d7c2a590b18a1e1d907cae65707013/p2p/transport.go#L94
161-
0x14_u8.encode(buf);
162161
Encoder::new(&mut encoded_data)
163162
.encode_field(&self.id)
164163
.encode_field(&self.block_headers)

crates/networking/p2p/rlpx/message.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,10 @@ impl Message {
6363
Message::Pong(msg) => msg.encode(buf),
6464
Message::Status(msg) => msg.encode(buf),
6565
Message::GetBlockHeaders(msg) => msg.encode(buf),
66-
Message::BlockHeaders(msg) => msg.encode(buf),
66+
Message::BlockHeaders(msg) => {
67+
0x14_u8.encode(buf);
68+
msg.encode(buf)
69+
}
6770
Message::GetAccountRange(msg) => {
6871
0x21_u8.encode(buf);
6972
msg.encode(buf)

0 commit comments

Comments
 (0)