chore(l1): cache tx hash (#4049)

**Motivation**

We saw that the hashing of txs takes a significant amount of time and
part of it is repeated.

**Description**

This PR create a new public hash function that allows to cache the
computation of the hash for subsequent calls.

After merging main there are some more changes needed. I'm taking a look
at them.

Closes #issue_number

Author: rodrigo-o

cmd/ef_tests/blockchain/types.rs

@@ -330,6 +330,7 @@ impl From<Transaction> for EIP1559Transaction {
             signature_y_parity: !val.v.is_zero(),
             signature_r: val.r,
             signature_s: val.s,
+            ..Default::default()
         }
     }
 }
@@ -362,6 +363,7 @@ impl From<Transaction> for EIP4844Transaction {
             signature_y_parity: !val.v.is_zero(),
             signature_r: val.r,
             signature_s: val.s,
+            ..Default::default()
         }
     }
 }
@@ -405,6 +407,7 @@ impl From<Transaction> for EIP7702Transaction {
             signature_y_parity: !val.v.is_zero(),
             signature_r: val.r,
             signature_s: val.s,
+            ..Default::default()
         }
     }
 }
@@ -425,6 +428,7 @@ impl From<Transaction> for LegacyTransaction {
             v: val.v,
             r: val.r,
             s: val.s,
+            ..Default::default()
         }
     }
 }
@@ -452,6 +456,7 @@ impl From<Transaction> for EIP2930Transaction {
             signature_y_parity: !val.v.is_zero(),
             signature_r: val.r,
             signature_s: val.s,
+            ..Default::default()
         }
     }
 }

cmd/ethrex_replay/src/run.rs

@@ -55,7 +55,7 @@ pub async fn run_tx(
         let (receipt, _) = vm.execute_tx(tx, &block.header, &mut remaining_gas, tx_sender)?;
         let account_updates = vm.get_state_transitions()?;
         wrapped_db.apply_account_updates(&account_updates)?;
-        if tx.compute_hash() == tx_hash {
+        if tx.hash() == tx_hash {
             return Ok((receipt, account_updates));
         }
     }

crates/blockchain/blockchain.rs

@@ -610,7 +610,7 @@ impl Blockchain {
         blobs_bundle.validate(&transaction, fork)?;
 
         let transaction = Transaction::EIP4844Transaction(transaction);
-        let hash = transaction.compute_hash();
+        let hash = transaction.hash();
         if self.mempool.contains_tx(hash)? {
             return Ok(hash);
         }
@@ -637,7 +637,7 @@ impl Blockchain {
         if matches!(transaction, Transaction::EIP4844Transaction(_)) {
             return Err(MempoolError::BlobTxNoBlobsBundle);
         }
-        let hash = transaction.compute_hash();
+        let hash = transaction.hash();
         if self.mempool.contains_tx(hash)? {
             return Ok(hash);
         }

crates/blockchain/mempool.rs

@@ -80,7 +80,7 @@ impl Mempool {
                 self.blobs_bundle_pool
                     .lock()
                     .map_err(|error| StoreError::Custom(error.to_string()))?
-                    .remove(&tx.compute_hash());
+                    .remove(hash);
             }
 
             self.txs_by_sender_nonce
@@ -283,7 +283,7 @@ impl Mempool {
         nonce: u64,
         tx: &Transaction,
     ) -> Result<Option<H256>, MempoolError> {
-        let Some(tx_in_pool) = self.contains_sender_nonce(sender, nonce, tx.compute_hash())? else {
+        let Some(tx_in_pool) = self.contains_sender_nonce(sender, nonce, tx.hash())? else {
             return Ok(None);
         };
 
@@ -321,7 +321,7 @@ impl Mempool {
             return Err(MempoolError::NonceTooLow);
         }
 
-        Ok(Some(tx_in_pool.compute_hash()))
+        Ok(Some(tx_in_pool.hash()))
     }
 }
 
@@ -768,8 +768,8 @@ mod tests {
         let blob_tx_decoded = Transaction::decode_canonical(&hex::decode("03f88f0780843b9aca008506fc23ac00830186a09400000000000000000000000000000000000001008080c001e1a0010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c44401401a0840650aa8f74d2b07f40067dc33b715078d73422f01da17abdbd11e02bbdfda9a04b2260f6022bf53eadb337b3e59514936f7317d872defb891a708ee279bdca90").unwrap()).unwrap();
         let blob_tx_sender = blob_tx_decoded.sender().unwrap();
         let blob_tx = MempoolTransaction::new(blob_tx_decoded, blob_tx_sender);
-        let plain_tx_hash = plain_tx.compute_hash();
-        let blob_tx_hash = blob_tx.compute_hash();
+        let plain_tx_hash = plain_tx.hash();
+        let blob_tx_hash = blob_tx.hash();
         let mempool = Mempool::new();
         let filter =
             |tx: &Transaction| -> bool { matches!(tx, Transaction::EIP4844Transaction(_)) };

crates/blockchain/payload.rs

@@ -410,25 +410,22 @@ impl Blockchain {
 
             // Check if we have enough gas to run the transaction
             if context.remaining_gas < head_tx.tx.gas_limit() {
-                debug!(
-                    "Skipping transaction: {}, no gas left",
-                    head_tx.tx.compute_hash()
-                );
+                debug!("Skipping transaction: {}, no gas left", head_tx.tx.hash());
                 // We don't have enough gas left for the transaction, so we skip all txs from this account
                 txs.pop();
                 continue;
             }
 
             // TODO: maybe fetch hash too when filtering mempool so we don't have to compute it here (we can do this in the same refactor as adding timestamp)
-            let tx_hash = head_tx.tx.compute_hash();
+            let tx_hash = head_tx.tx.hash();
 
             // Check whether the tx is replay-protected
             if head_tx.tx.protected() && !chain_config.is_eip155_activated(context.block_number()) {
                 // Ignore replay protected tx & all txs from the sender
                 // Pull transaction from the mempool
                 debug!("Ignoring replay-protected transaction: {}", tx_hash);
                 txs.pop();
-                self.remove_transaction_from_pool(&head_tx.tx.compute_hash())?;
+                self.remove_transaction_from_pool(&tx_hash)?;
                 continue;
             }
 
@@ -437,7 +434,7 @@ impl Blockchain {
                 Ok(receipt) => {
                     txs.shift()?;
                     // Pull transaction from the mempool
-                    self.remove_transaction_from_pool(&head_tx.tx.compute_hash())?;
+                    self.remove_transaction_from_pool(&tx_hash)?;
 
                     metrics!(METRICS_TX.inc_tx_with_type(MetricsTxType(head_tx.tx_type())));
                     receipt
@@ -479,7 +476,7 @@ impl Blockchain {
         context: &mut PayloadBuildContext,
     ) -> Result<Receipt, ChainError> {
         // Fetch blobs bundle
-        let tx_hash = head.tx.compute_hash();
+        let tx_hash = head.tx.hash();
         let chain_config = context.chain_config()?;
         let max_blob_number_per_block = chain_config
             .get_fork_blob_schedule(context.payload.header.timestamp)

crates/blockchain/tracing.rs

@@ -70,7 +70,7 @@ impl Blockchain {
             // We are cloning the `Arc`s here, not the structs themselves
             let block = block.clone();
             let vm = vm.clone();
-            let tx_hash = block.as_ref().body.transactions[index].compute_hash();
+            let tx_hash = block.as_ref().body.transactions[index].hash();
             let call_trace = timeout_trace_operation(timeout, move || {
                 vm.lock()
                     .map_err(|_| EvmError::Custom("Unexpected Runtime Error".to_string()))?