Skip to content

Commit 0dc0d27

Browse files
reduce felt with converting into qm31
1 parent bb721e5 commit 0dc0d27

File tree

1 file changed

+5
-5
lines changed
  • crates/starknet-types-core/src/felt

1 file changed

+5
-5
lines changed

crates/starknet-types-core/src/felt/qm31.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ impl fmt::Display for QM31Error {
2121
match self {
2222
QM31Error::FeltTooBig(felt) => writeln!(
2323
f,
24-
"Number used as QM31 since it's more than 144 bits long: {}",
25-
felt
24+
"Number used as QM31 since it's more than 144 bits long: {felt}"
2625
),
2726
QM31Error::InvalidInversion => writeln!(f, "Attempt to invert a qm31 equal to zero"),
2827
}
@@ -239,7 +238,7 @@ impl TryFrom<Felt> for QM31Felt {
239238
return Err(QM31Error::FeltTooBig(value));
240239
}
241240

242-
Ok(Self(limbs))
241+
Ok(Self::from_raw(limbs))
243242
}
244243
}
245244

@@ -256,7 +255,7 @@ impl TryFrom<&Felt> for QM31Felt {
256255
return Err(QM31Error::FeltTooBig(*value));
257256
}
258257

259-
Ok(Self(limbs))
258+
Ok(Self::from_raw(limbs))
260259
}
261260
}
262261

@@ -274,8 +273,9 @@ mod test {
274273
};
275274

276275
#[test]
277-
fn from_qm31_to_felt() {
276+
fn from_positive_felt_to_qm31_to_felt() {
278277
let felt_expected = Felt::from(2i128.pow(126));
278+
279279
let qm31: QM31Felt = felt_expected.try_into().unwrap();
280280
let felt = qm31.into();
281281

0 commit comments

Comments
 (0)