Skip to content

Commit 0251aaf

Browse files
xuelinkxuelink
committed
refactor: comment out unused styles and add aria-labels for accessibility
1 parent de376eb commit 0251aaf

File tree

7 files changed

+102
-75
lines changed

7 files changed

+102
-75
lines changed

‎src/lib/components/organisms/About.svelte

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,19 @@
7575
}
7676
}
7777
78-
.socials {
79-
display: flex;
80-
align-items: center;
81-
gap: 15px;
78+
// .socials {
79+
// display: flex;
80+
// align-items: center;
81+
// gap: 15px;
8282
83-
@mixin for-phone-only {
84-
justify-content: center;
85-
margin-bottom: 10px;
86-
span {
87-
display: none;
88-
}
89-
}
90-
}
83+
// @mixin for-phone-only {
84+
// justify-content: center;
85+
// margin-bottom: 10px;
86+
// span {
87+
// display: none;
88+
// }
89+
// }
90+
// }
9191
9292
.image {
9393
width: 100%;
@@ -103,9 +103,9 @@
103103
font-size: 1.2em;
104104
}
105105
106-
.github {
107-
margin-left: 5px;
108-
}
106+
// .github {
107+
// margin-left: 5px;
108+
// }
109109
110110
a {
111111
transition: all 0.2s ease-in-out;

‎src/lib/components/organisms/BCSponsors.svelte

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
<h2>Powered by Growing Companies Worldwide</h2>
44
<div class="sponsor-container">
55
<div>
6-
<a href="https://www.cloudflare.com" target="_blank" rel="noopener noreferrer">
6+
<a
7+
href="https://www.cloudflare.com"
8+
target="_blank"
9+
rel="noopener noreferrer"
10+
aria-label="Cloudflare"
11+
>
712
<svg
813
fill="var(--color--text)"
914
width="58px"
@@ -26,7 +31,12 @@
2631
</a>
2732
</div>
2833
<div>
29-
<a href="https://www.digitalocean.com" target="_blank" rel="noopener noreferrer">
34+
<a
35+
href="https://www.digitalocean.com"
36+
target="_blank"
37+
rel="noopener noreferrer"
38+
aria-label="DigitalOcean"
39+
>
3040
<svg
3141
width="52px"
3242
height="52px"
@@ -50,7 +60,12 @@
5060
</a>
5161
</div>
5262
<div>
53-
<a href="https://www.backblaze.com" target="_blank" rel="noopener noreferrer">
63+
<a
64+
href="https://www.backblaze.com"
65+
target="_blank"
66+
rel="noopener noreferrer"
67+
aria-label="Backblaze"
68+
>
5469
<svg
5570
width="50px"
5671
height="50px"
@@ -71,7 +86,7 @@
7186
</a>
7287
</div>
7388
<div>
74-
<a href="https://nodejs.org" target="_blank" rel="noopener noreferrer">
89+
<a href="https://nodejs.org" target="_blank" rel="noopener noreferrer" aria-label="Node.js">
7590
<svg
7691
width="50px"
7792
height="50px"
@@ -93,7 +108,12 @@
93108
</a>
94109
</div>
95110
<div>
96-
<a href="https://appwrite.io" target="_blank" rel="noopener noreferrer">
111+
<a
112+
href="https://appwrite.io"
113+
target="_blank"
114+
rel="noopener noreferrer"
115+
aria-label="Appwrite"
116+
>
97117
<svg
98118
xmlns="http://www.w3.org/2000/svg"
99119
width="45"

‎src/lib/components/organisms/CSponsors.svelte

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,12 @@
3636
</a>
3737
</div>
3838
<div>
39-
<a href="https://facebook.com" target="_blank" rel="noopener noreferrer">
39+
<a
40+
href="https://facebook.com"
41+
target="_blank"
42+
rel="noopener noreferrer"
43+
aria-label="Facebook"
44+
>
4045
<svg
4146
width="68px"
4247
height="68px"
@@ -56,7 +61,7 @@
5661
</a>
5762
</div>
5863
<div>
59-
<a href="https://tiktok.com" target="_blank" rel="noopener noreferrer">
64+
<a href="https://tiktok.com" target="_blank" rel="noopener noreferrer" aria-label="TikTok">
6065
<svg
6166
fill="var(--color--text)"
6267
width="50px"
@@ -75,7 +80,7 @@
7580
</a>
7681
</div>
7782
<div>
78-
<a href="https://google.com" target="_blank" rel="noopener noreferrer">
83+
<a href="https://google.com" target="_blank" rel="noopener noreferrer" aria-label="Google">
7984
<svg
8085
width="45px"
8186
height="45px"
@@ -188,7 +193,7 @@
188193
</a>
189194
</div>
190195
<div>
191-
<a href="https://huawei.com" target="_blank" rel="noopener noreferrer">
196+
<a href="https://huawei.com" target="_blank" rel="noopener noreferrer" aria-label="Huawei">
192197
<svg
193198
xmlns="http://www.w3.org/2000/svg"
194199
width="50"
@@ -221,9 +226,9 @@
221226
text-align: center;
222227
}
223228
224-
.second-sponsor {
225-
margin-top: 80px;
226-
}
229+
// .second-sponsor {
230+
// margin-top: 80px;
231+
// }
227232
228233
.sponsor-container {
229234
display: grid;

‎src/lib/components/organisms/FAQ.svelte

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,8 @@
113113
}}
114114
id="accordion-button-5"
115115
aria-expanded={item?.isOpen}
116-
><span class="accordion-title">{item?.title}</span><span
117-
class="icon"
118-
aria-hidden="true"
119-
/></button
116+
><span class="accordion-title">{item?.title}</span><span class="icon" aria-hidden="true"
117+
></span></button
120118
>
121119
<div class="accordion-content">
122120
<p>{@html item?.content}</p>
@@ -129,7 +127,7 @@
129127

130128
<style lang="scss">
131129
@use '../../../lib/scss/breakpoints.scss';
132-
130+
133131
#faq {
134132
display: flex;
135133
flex-direction: column;
@@ -143,9 +141,9 @@
143141
padding: 40px 0 50px;
144142
}
145143
146-
.hello {
147-
text-align: center;
148-
}
144+
// .hello {
145+
// text-align: center;
146+
// }
149147
}
150148
151149
$yellow: var(--color--primary);
@@ -254,7 +252,9 @@
254252
opacity: 0;
255253
max-height: 0;
256254
overflow: hidden;
257-
transition: opacity 200ms linear, max-height 200ms linear;
255+
transition:
256+
opacity 200ms linear,
257+
max-height 200ms linear;
258258
will-change: opacity, max-height;
259259
260260
p {

‎src/lib/components/organisms/Footer.svelte

Lines changed: 32 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
</div>
165165
</div>
166166
<div class="footer-logo">
167-
<a href="/">
167+
<a href="/" aria-label="LangX">
168168
<svg xmlns="http://www.w3.org/2000/svg" width="100.852" height="21.544">
169169
<path
170170
fill="#000"
@@ -242,35 +242,37 @@
242242
grid-row-start: 1;
243243
}
244244
245-
.credits {
246-
position: relative;
247-
background-color: var(--color--yellow);
248-
border-radius: 5px;
249-
padding: 15px 10px;
250-
font-weight: 400;
251-
font-size: 80%;
252-
color: var(--color--text);
253-
margin-top: 1rem;
254-
box-shadow: 10px 10px 3px rgba(0, 0, 0, 0.5), 0 0 8px rgba(0, 0, 0, 0.5);
255-
max-width: 400px;
256-
257-
@mixin for-phone-only {
258-
display: none;
259-
}
260-
261-
a {
262-
color: var(--color--text);
263-
text-decoration: none;
264-
transition: all 0.2s ease-in-out;
265-
font-weight: bold;
266-
267-
&:hover {
268-
color: var(--color--text);
269-
filter: drop-shadow(0px 0px 3px var(--color--text-shade));
270-
transition: color 0.5s ease-in-out;
271-
}
272-
}
273-
}
245+
// .credits {
246+
// position: relative;
247+
// background-color: var(--color--yellow);
248+
// border-radius: 5px;
249+
// padding: 15px 10px;
250+
// font-weight: 400;
251+
// font-size: 80%;
252+
// color: var(--color--text);
253+
// margin-top: 1rem;
254+
// box-shadow:
255+
// 10px 10px 3px rgba(0, 0, 0, 0.5),
256+
// 0 0 8px rgba(0, 0, 0, 0.5);
257+
// max-width: 400px;
258+
259+
// @mixin for-phone-only {
260+
// display: none;
261+
// }
262+
263+
// a {
264+
// color: var(--color--text);
265+
// text-decoration: none;
266+
// transition: all 0.2s ease-in-out;
267+
// font-weight: bold;
268+
269+
// &:hover {
270+
// color: var(--color--text);
271+
// filter: drop-shadow(0px 0px 3px var(--color--text-shade));
272+
// transition: color 0.5s ease-in-out;
273+
// }
274+
// }
275+
// }
274276
}
275277
276278
.links-wrapper {

‎src/lib/components/organisms/Testimonials.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@
180180
</div>
181181
</div>
182182
{/each}
183-
<button id="next" on:click={handleNext}>
183+
<button id="next" on:click={handleNext} aria-label="Next">
184184
<svg
185185
xmlns="http://www.w3.org/2000/svg"
186186
fill="none"
@@ -191,7 +191,7 @@
191191
<path stroke-linecap="round" stroke-linejoin="round" d="m8.25 4.5 7.5 7.5-7.5 7.5" />
192192
</svg>
193193
</button>
194-
<button id="prev" on:click={handlePrev}>
194+
<button id="prev" on:click={handlePrev} aria-label="Previous">
195195
<svg
196196
xmlns="http://www.w3.org/2000/svg"
197197
fill="none"
@@ -214,7 +214,7 @@
214214
active = index;
215215
loadShow();
216216
}}
217-
/>
217+
></span>
218218
{/each}
219219
</div>
220220
</section>

‎src/routes/(blog-article)/+layout.svelte

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,12 @@
153153
box-shadow: var(--image-shadow);
154154
border-radius: 6px;
155155
156-
img {
157-
width: 100%;
158-
height: 100%;
159-
max-height: 400px;
160-
object-fit: cover;
161-
}
156+
// img {
157+
// width: 100%;
158+
// height: 100%;
159+
// max-height: 400px;
160+
// object-fit: cover;
161+
// }
162162
}
163163
164164
:global(.cover-image img) {

0 commit comments

Comments
 (0)