Skip to content

Commit 5791df0

Browse files
committed
FIX: variable_mc_capcontrol kwargs
was missing report and relax in each instance of variable_mc_capcontrol
1 parent 9cbecb4 commit 5791df0

File tree

9 files changed

+25
-19
lines changed

9 files changed

+25
-19
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
- none
66

7+
## v0.14.1
8+
9+
- Fix `variable_mc_capcontrol` keyword arguments
10+
711
## v0.14.0
812

913
- Drop support for JuMP < v0.22

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name = "PowerModelsDistribution"
22
uuid = "d7431456-977f-11e9-2de3-97ff7677985e"
33
authors = ["David M Fobes <dfobes@lanl.gov>", "Carleton Coffrin"]
44
repo = "https://github.com/lanl-ansi/PowerModelsDistribution.jl.git"
5-
version = "0.14.0"
5+
version = "0.14.1"
66

77
[deps]
88
CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"

src/core/variable.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ end
762762
763763
Capacitor (with capcontrol) relaxed power variables for AbstractLPUBFModel (using McCormick envelopes)
764764
"""
765-
function variable_mc_capacitor_reactive_power(pm::AbstractUnbalancedPowerModel; nw::Int=nw_id_default)
765+
function variable_mc_capacitor_reactive_power(pm::AbstractUnbalancedPowerModel; nw::Int=nw_id_default, report::Bool=false)
766766
cap_switch_ids = [id for (id,cap) in ref(pm, nw, :shunt) if haskey(cap,"controls")]
767767
cap_reactive_power = var(pm, nw)[:capacitor_reactive_power] = Dict(
768768
i => JuMP.@variable(
@@ -771,6 +771,8 @@ function variable_mc_capacitor_reactive_power(pm::AbstractUnbalancedPowerModel;
771771
base_name="$(nw)_cap_cur_$(i)",
772772
) for i in cap_switch_ids
773773
)
774+
775+
report && _IM.sol_component_value(pm, pmd_it_sym, nw, :shunt, :capacitor_reactive_power, cap_switch_ids, cap_reactive_power)
774776
end
775777

776778

src/form/acp.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,12 @@ end
6969

7070

7171
"""
72-
variable_mc_capcontrol(pm::AbstractUnbalancedACPModel; nw::Int=nw_id_default, relax::Bool=false)
72+
variable_mc_capcontrol(pm::AbstractUnbalancedACPModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
7373
7474
Capacitor switching variables.
7575
"""
76-
function variable_mc_capcontrol(pm::AbstractUnbalancedACPModel; nw::Int=nw_id_default, relax::Bool=false)
77-
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax)
76+
function variable_mc_capcontrol(pm::AbstractUnbalancedACPModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
77+
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax, report=report)
7878
end
7979

8080

src/form/acr.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@ end
108108

109109

110110
"""
111-
variable_mc_capcontrol(pm::AbstractUnbalancedACRModel; nw::Int=nw_id_default, relax::Bool=false)
111+
variable_mc_capcontrol(pm::AbstractUnbalancedACRModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
112112
113113
Capacitor switching variables.
114114
"""
115-
function variable_mc_capcontrol(pm::AbstractUnbalancedACRModel; nw::Int=nw_id_default, relax::Bool=false)
116-
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax)
115+
function variable_mc_capcontrol(pm::AbstractUnbalancedACRModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
116+
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax, report=report)
117117
end
118118

119119

src/form/apo.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ end
7979

8080

8181
"nothing to do, these models do not have complex voltage variables"
82-
function variable_mc_capcontrol(pm::AbstractUnbalancedNFAModel; nw::Int=nw_id_default, bounded::Bool=true, report::Bool=true)
82+
function variable_mc_capcontrol(pm::AbstractUnbalancedNFAModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
8383
end
8484

8585

src/form/bf_fbs.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,12 @@ end
9090

9191

9292
"""
93-
variable_mc_capcontrol(pm::FBSUBFPowerModel; nw::Int=nw_id_default, relax::Bool=false)
93+
variable_mc_capcontrol(pm::FBSUBFPowerModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
9494
9595
Capacitor switching variables.
9696
"""
97-
function variable_mc_capcontrol(pm::FBSUBFPowerModel; nw::Int=nw_id_default, relax::Bool=false)
98-
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax)
97+
function variable_mc_capcontrol(pm::FBSUBFPowerModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
98+
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax, report=report)
9999
end
100100

101101

src/form/bf_mx_lin.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ end
2222

2323

2424
"""
25-
variable_mc_capcontrol(pm::AbstractLPUBFModel; nw::Int=nw_id_default, relax::Bool=false)
25+
variable_mc_capcontrol(pm::AbstractLPUBFModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
2626
2727
Capacitor switching and relaxed power variables.
2828
"""
29-
function variable_mc_capcontrol(pm::AbstractLPUBFModel; nw::Int=nw_id_default, relax::Bool=false)
30-
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax)
31-
variable_mc_capacitor_reactive_power(pm; nw=nw)
29+
function variable_mc_capcontrol(pm::AbstractLPUBFModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
30+
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax, report=report)
31+
variable_mc_capacitor_reactive_power(pm; nw=nw, report=report)
3232
end
3333

3434

src/form/fotr.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,12 @@ end
5858

5959

6060
"""
61-
variable_mc_capcontrol(pm::FOTRUPowerModel; nw::Int=nw_id_default, relax::Bool=false)
61+
variable_mc_capcontrol(pm::FOTRUPowerModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
6262
6363
Capacitor switching variables.
6464
"""
65-
function variable_mc_capcontrol(pm::FOTRUPowerModel; nw::Int=nw_id_default, relax::Bool=false)
66-
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax)
65+
function variable_mc_capcontrol(pm::FOTRUPowerModel; nw::Int=nw_id_default, relax::Bool=false, report::Bool=true)
66+
variable_mc_capacitor_switch_state(pm; nw=nw, relax=relax, report=report)
6767
end
6868

6969

0 commit comments

Comments
 (0)