UPD: 1phase pv case for dss validation

Uses dss results for validation

Author: pseudocubic

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## staged
 
+- Fixed `1phase-pv` unit tests
 - Adjusted `sbase_default`, and added `@info` if basemva from dss is the default value
 - Fixed storage model for powerflow validation (new test values are based directly on dss outputs)
 - Added `con(pm, nw, :ohms_yt, f_idx)` to store ohms constraints

src/data_model/eng2math.jl

@@ -735,6 +735,9 @@ function _map_eng2math_generator!(data_math::Dict{String,<:Any}, data_eng::Dict{
             end
         end
 
+        math_obj["pg"] = get(eng_obj, "pg", fill(0.0, length(connections)))
+        math_obj["qg"] = get(eng_obj, "qg", fill(0.0, length(connections)))
+
         _add_gen_cost_model!(math_obj, eng_obj)
 
         math_obj["configuration"] = get(eng_obj, "configuration", WYE)
@@ -755,6 +758,8 @@ function _map_eng2math_solar!(data_math::Dict{String,<:Any}, data_eng::Dict{Stri
     for (name, eng_obj) in get(data_eng, "solar", Dict{Any,Dict{String,Any}}())
         math_obj = _init_math_obj("solar", name, eng_obj, length(data_math["gen"])+1; pass_props=pass_props)
 
+        connections = eng_obj["connections"]
+
         math_obj["gen_bus"] = data_math["bus_lookup"][eng_obj["bus"]]
         math_obj["gen_status"] = status = Int(eng_obj["status"])
 
@@ -780,6 +785,9 @@ function _map_eng2math_solar!(data_math::Dict{String,<:Any}, data_eng::Dict{Stri
             math_obj[to_k] = haskey(eng_obj, fr_k) ? eng_obj[fr_k] : fill(def, N)
         end
 
+        math_obj["pg"] = get(eng_obj, "pg", fill(0.0, N))
+        math_obj["qg"] = get(eng_obj, "qg", fill(0.0, N))
+
         _add_gen_cost_model!(math_obj, eng_obj)
 
         data_math["gen"]["$(math_obj["index"])"] = math_obj

test/data/opendss/case3_unbalanced_1phase-pv.dss

@@ -1,20 +1,23 @@
 Clear
 New Circuit.3Bus_example
 !  define a really stiff source
-~ basekv=0.4   pu=0.9959  MVAsc1=1e6  MVAsc3=1e6
+~ basekv=0.4   pu=1.0  MVAsc1=1e6  MVAsc3=1e6 basemva=0.001
 
 !Define Linecodes
 New linecode.556MCM nphases=3 basefreq=50  ! ohms per 5 mile
 ~ rmatrix = ( 0.1000 | 0.0400    0.1000 |  0.0400    0.0400    0.1000)
 ~ xmatrix = ( 0.0583 |  0.0233    0.0583 | 0.0233    0.0233    0.0583)
 ~ cmatrix = (50.92958178940651  | -0  50.92958178940651 | -0 -0 50.92958178940651  ) ! small capacitance
 
-
 New linecode.4/0QUAD nphases=3 basefreq=50  ! ohms per 100ft
 ~ rmatrix = ( 0.1167 | 0.0467    0.1167 | 0.0467    0.0467    0.1167)
 ~ xmatrix = (0.0667  |  0.0267    0.0667  |  0.0267    0.0267    0.0667 )
 ~ cmatrix = (50.92958178940651  | -0  50.92958178940651 | -0 -0 50.92958178940651  )  ! small capacitance
 
+!Define loadshapes
+
+New loadshape.dailyshape npts=1 minterval=60 mult=[ 1 ]
+
 !Define lines
 
 New Line.OHLine  bus1=sourcebus.1.2.3  Primary.1.2.3  linecode = 556MCM   length=1  ! 5 mile line
@@ -26,7 +29,7 @@ New Load.L1 phases=1  loadbus.1.0   ( 0.4 3 sqrt / )   kW=8   kvar=3  model=1
 New Load.L2 phases=1  loadbus.2.0   ( 0.4 3 sqrt / )   kW=6   kvar=3  model=1
 New Load.L3 phases=1  loadbus.3.0   ( 0.4 3 sqrt / )   kW=6   kvar=3  model=1
 
-New PVSystem.PV1 phases=1 bus1=primary.1 kv=0.4 kva=2 kvar=2
+New PVSystem.PV1 phases=1 bus1=primary.1 kv=( 0.4 3 sqrt / ) pmpp=2 irradiance=1 kva=2 daily=dailyshape
 
 Set voltagebases=[0.4]
 Set tolerance=0.000001

test/opf.jl

@@ -209,10 +209,14 @@
         @test result["termination_status"] == LOCALLY_SOLVED
 
         @test isapprox(sum(result["solution"]["voltage_source"]["source"]["pg"]), 18.38728; atol=1e-2)
-        @test isapprox(sum(result["solution"]["voltage_source"]["source"]["qg"]),  7.28903; atol=1e-2)
+        @test isapprox(sum(result["solution"]["voltage_source"]["source"]["qg"]),  9.21713; atol=1e-2)
 
         @test all(isapprox(sum(result["solution"]["solar"]["pv1"]["pg"]), 1.9947; atol=1e-2))
-        @test all(isapprox(sum(result["solution"]["solar"]["pv1"]["qg"]), 1.9259; atol=1e-2))
+        @test all(isapprox(sum(result["solution"]["solar"]["pv1"]["qg"]), 0.0; atol=1e-2))
+
+        vbase = case3_unbalanced_1phase_pv["settings"]["vbases_default"]["sourcebus"]
+        @test all(isapprox(result["solution"]["bus"]["primary"]["vm"] ./ vbase, [0.990984, 0.991149, 0.991134]; atol=1e-3))
+        @test all(isapprox(result["solution"]["bus"]["primary"]["va"], [-0.03, -120.03, 119.97]; atol=1e-2))
     end
 
     @testset "3-bus balanced capacitor acp opf" begin