native_midi_common.c (ReadMIDIFile): fix possible NULL ptr dereference.

sezero · sezero · commit 59caf947bd0b · 2024-05-25T23:11:20.000+03:00
if allocation of mididata->track ever fails we'd still be dereferencing it under 'bail' (cherry picked from commit 9c5ccc0)
diff --git a/src/codecs/native_midi/native_midi_common.c b/src/codecs/native_midi/native_midi_common.c
@@ -262,7 +262,7 @@ static MIDIEvent *MIDItoStream(MIDIFile *mididata)
 
 static int ReadMIDIFile(MIDIFile *mididata, SDL_RWops *src)
 {
-    int i = 0;
+    int i = -1;
     Uint32 ID;
     Uint32 size;
     Uint16 format;

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ static MIDIEvent MIDItoStream(MIDIFile mididata)`
`262`	`262`
`263`	`263`	`static int ReadMIDIFile(MIDIFile mididata, SDL_RWops src)`
`264`	`264`	`{`
`265`		`- int i = 0;`
	`265`	`+ int i = -1;`
`266`	`266`	`Uint32 ID;`
`267`	`267`	`Uint32 size;`
`268`	`268`	`Uint16 format;`