Skip to content

Commit f8d8549

Browse files
committed
SDL_mixer_metadata_tags.c:parse_id3v1_ansi_string(): Fixed "always true" expression
1 parent bd7fd21 commit f8d8549

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/SDL_mixer_metadata_tags.c

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,17 @@ static char *parse_id3v1_ansi_string(const Uint8 *buffer, size_t src_len)
9696
src_buffer[src_len] = '\0';
9797

9898
// trim whitespace from end (some id3v1 tags pad out with space instead of nulls).
99-
for (size_t i = src_len - 1; (i >= 0) && (src_buffer[i] == ' '); i--) {
100-
src_buffer[i] = '\0';
101-
src_len--;
99+
if (src_len > 0) {
100+
size_t i = src_len;
101+
do {
102+
--i;
103+
if (src_buffer[i] == ' ') {
104+
src_buffer[i] = '\0';
105+
--src_len;
106+
} else {
107+
break;
108+
}
109+
} while(i > 0);
102110
}
103111

104112
char *ret = SDL_iconv_string("UTF-8", "ISO-8859-1", src_buffer, src_len + 1);

0 commit comments

Comments
 (0)