Skip to content

Commit 54bd517

Browse files
committed
Fixes from review
1 parent 16a9c7a commit 54bd517

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

internal/controller/linodemachine_controller.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -795,23 +795,23 @@ func (r *LinodeMachineReconciler) reconcileFirewallID(ctx context.Context, logge
795795
return ctrl.Result{RequeueAfter: reconciler.DefaultMachineControllerWaitForRunningDelay}, nil
796796
}
797797

798-
attachedFirewalls := make([]int, 0, len(firewalls))
798+
attachedFWIDs := make([]int, 0, len(firewalls))
799799
for _, fw := range firewalls {
800-
attachedFirewalls = append(attachedFirewalls, fw.ID)
800+
attachedFWIDs = append(attachedFWIDs, fw.ID)
801801
}
802802

803-
var desiredFirewalls []int
803+
var desiredFWIDs []int
804804
if machineScope.LinodeMachine.Spec.FirewallID != 0 {
805-
desiredFirewalls = []int{machineScope.LinodeMachine.Spec.FirewallID}
805+
desiredFWIDs = []int{machineScope.LinodeMachine.Spec.FirewallID}
806806
} else {
807-
desiredFirewalls = []int{}
807+
desiredFWIDs = []int{}
808808
}
809809

810810
// update the firewallID if needed.
811-
if !slices.Equal(attachedFirewalls, desiredFirewalls) {
811+
if !slices.Equal(attachedFWIDs, desiredFWIDs) {
812812
_, err := machineScope.LinodeClient.UpdateInstanceFirewalls(ctx, instanceID,
813813
linodego.InstanceFirewallUpdateOptions{
814-
FirewallIDs: desiredFirewalls,
814+
FirewallIDs: desiredFWIDs,
815815
},
816816
)
817817
if err != nil {

0 commit comments

Comments
 (0)