allow setting allocation_class if provided

Author: rahulait

internal/controller/linodevpc_controller_helpers.go

@@ -171,6 +171,9 @@ func linodeVPCSpecToVPCCreateConfig(vpcSpec infrav1alpha2.LinodeVPCSpec) *linode
 		vpcIPv6[idx] = linodego.VPCCreateOptionsIPv6{
 			Range: ipv6.Range,
 		}
+		if ipv6.AllocationClass != nil {
+			vpcIPv6[idx].AllocationClass = ipv6.AllocationClass
+		}
 	}
 
 	subnets := make([]linodego.VPCSubnetCreateOptions, len(vpcSpec.Subnets))

internal/controller/linodevpc_controller_helpers_test.go

@@ -1,27 +1,150 @@
 package controller
 
 import (
+	"reflect"
 	"testing"
 
-	"github.com/stretchr/testify/assert"
+	"github.com/linode/linodego"
+	"k8s.io/utils/ptr"
 
 	infrav1alpha2 "github.com/linode/cluster-api-provider-linode/api/v1alpha2"
 )
 
-func TestLinodeVPCSpecToCreateVPCConfig(t *testing.T) {
+func Test_linodeVPCSpecToVPCCreateConfig(t *testing.T) {
 	t.Parallel()
-
-	vpcSpec := infrav1alpha2.LinodeVPCSpec{
-		Description: "description",
-		Region:      "region",
-		Subnets: []infrav1alpha2.VPCSubnetCreateOptions{
-			{
-				Label: "subnet",
-				IPv4:  "ipv4",
+	type args struct {
+		vpcSpec infrav1alpha2.LinodeVPCSpec
+	}
+	tests := []struct {
+		name string
+		args args
+		want *linodego.VPCCreateOptions
+	}{
+		{
+			name: "no ipv6 ranges",
+			args: args{
+				vpcSpec: infrav1alpha2.LinodeVPCSpec{
+					Description: "description",
+					Region:      "region",
+					Subnets: []infrav1alpha2.VPCSubnetCreateOptions{
+						{
+							Label: "subnet",
+							IPv4:  "ipv4",
+						},
+					},
+				},
+			},
+			want: &linodego.VPCCreateOptions{
+				Description: "description",
+				Region:      "region",
+				Subnets: []linodego.VPCSubnetCreateOptions{
+					{
+						Label: "subnet",
+						IPv4:  "ipv4",
+						IPv6:  []linodego.VPCSubnetCreateOptionsIPv6{},
+					},
+				},
+				IPv6: []linodego.VPCCreateOptionsIPv6{},
+			},
+		},
+		{
+			name: "ipv6 ranges without allocation_class",
+			args: args{
+				vpcSpec: infrav1alpha2.LinodeVPCSpec{
+					Description: "description",
+					Region:      "region",
+					IPv6Range: []infrav1alpha2.VPCCreateOptionsIPv6{
+						{
+							Range: ptr.To("2001:db8::/52"),
+						},
+					},
+					Subnets: []infrav1alpha2.VPCSubnetCreateOptions{
+						{
+							Label: "subnet",
+							IPv4:  "ipv4",
+							IPv6Range: []infrav1alpha2.VPCSubnetCreateOptionsIPv6{
+								{
+									Range: ptr.To("2001:db8:1::/56"),
+								},
+							},
+						},
+					},
+				},
+			},
+			want: &linodego.VPCCreateOptions{
+				Description: "description",
+				Region:      "region",
+				Subnets: []linodego.VPCSubnetCreateOptions{
+					{
+						Label: "subnet",
+						IPv4:  "ipv4",
+						IPv6: []linodego.VPCSubnetCreateOptionsIPv6{
+							{
+								Range: ptr.To("2001:db8:1::/56"),
+							},
+						},
+					},
+				},
+				IPv6: []linodego.VPCCreateOptionsIPv6{
+					{
+						Range: ptr.To("2001:db8::/52"),
+					},
+				},
+			},
+		},
+		{
+			name: "ipv6 ranges with allocation_class",
+			args: args{
+				vpcSpec: infrav1alpha2.LinodeVPCSpec{
+					Description: "description",
+					Region:      "region",
+					IPv6Range: []infrav1alpha2.VPCCreateOptionsIPv6{
+						{
+							Range:           ptr.To("2001:db8::/52"),
+							AllocationClass: ptr.To("myclass"),
+						},
+					},
+					Subnets: []infrav1alpha2.VPCSubnetCreateOptions{
+						{
+							Label: "subnet",
+							IPv4:  "ipv4",
+							IPv6Range: []infrav1alpha2.VPCSubnetCreateOptionsIPv6{
+								{
+									Range: ptr.To("2001:db8:1::/56"),
+								},
+							},
+						},
+					},
+				},
+			},
+			want: &linodego.VPCCreateOptions{
+				Description: "description",
+				Region:      "region",
+				Subnets: []linodego.VPCSubnetCreateOptions{
+					{
+						Label: "subnet",
+						IPv4:  "ipv4",
+						IPv6: []linodego.VPCSubnetCreateOptionsIPv6{
+							{
+								Range: ptr.To("2001:db8:1::/56"),
+							},
+						},
+					},
+				},
+				IPv6: []linodego.VPCCreateOptionsIPv6{
+					{
+						Range:           ptr.To("2001:db8::/52"),
+						AllocationClass: ptr.To("myclass"),
+					},
+				},
 			},
 		},
 	}
-
-	createConfig := linodeVPCSpecToVPCCreateConfig(vpcSpec)
-	assert.NotNil(t, createConfig, "Failed to convert LinodeVPCSpec to VPCCreateOptions")
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := linodeVPCSpecToVPCCreateConfig(tt.args.vpcSpec); !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("linodeVPCSpecToVPCCreateConfig() = %v, want %v", got, tt.want)
+			}
+		})
+	}
 }