[fix] golangci-lint is unlocked to use the latest version again (#489)

* 'exportloopref' is deprecated replaced with copyloopvar

* reconfiguring to use latest lint version

* port range is safe for int32 conversion, ignoring the nosec

* always passing the formatting string in required func

Author: unnatiagg

.github/workflows/go-analyze.yml

@@ -68,7 +68,7 @@ jobs:
       - name: lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.59.1
+          version: latest
 
       - name: Nilcheck
         run: make nilcheck

.golangci.yml

@@ -138,9 +138,8 @@ linters:
     - errname
     - errorlint
     - errcheck
-    - exportloopref
+    - copyloopvar
     - exhaustive
-    - exportloopref
     - forbidigo
     - forcetypeassert
     # - funlen
@@ -205,7 +204,7 @@ issues:
         - errcheck
         - dupl
         - gosec
-        - exportloopref
+        - copyloopvar
         - unparam
     # conversion files rely on largely generated code so are very similar
     - path: _conversion\.go

Makefile

@@ -125,7 +125,7 @@ gosec: ## Run gosec against code.
 
 .PHONY: lint
 lint: ## Run lint against code.
-	docker run --rm -w /workdir -v $(PWD):/workdir golangci/golangci-lint:v1.59.1 golangci-lint run -c .golangci.yml --fix
+	docker run --rm -w /workdir -v $(PWD):/workdir golangci/golangci-lint:latest golangci-lint run -c .golangci.yml --fix
 
 .PHONY: nilcheck
 nilcheck: nilaway ## Run nil check against code.

controller/linodecluster_controller_helpers.go

@@ -160,7 +160,7 @@ func handleDNS(clusterScope *scope.ClusterScope) {
 	}
 	clusterScope.LinodeCluster.Spec.ControlPlaneEndpoint = clusterv1.APIEndpoint{
 		Host: dnsHost,
-		Port: int32(apiLBPort),
+		Port: int32(apiLBPort), // #nosec G115: Integer overflow conversion is safe for port numbers
 	}
 }
 
@@ -196,7 +196,7 @@ func handleNBCreate(ctx context.Context, logger logr.Logger, clusterScope *scope
 
 	clusterScope.LinodeCluster.Spec.ControlPlaneEndpoint = clusterv1.APIEndpoint{
 		Host: *linodeNB.IPv4,
-		Port: int32(configs[0].Port),
+		Port: int32(configs[0].Port), // #nosec G115: Integer overflow conversion is safe for port numbers
 	}
 
 	return nil

controller/linodefirewall_controller.go

@@ -115,7 +115,7 @@ func (r *LinodeFirewallReconciler) reconcile(
 		if err != nil {
 			fwScope.LinodeFirewall.Status.FailureReason = util.Pointer(failureReason)
 			fwScope.LinodeFirewall.Status.FailureMessage = util.Pointer(err.Error())
-			conditions.MarkFalse(fwScope.LinodeFirewall, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, err.Error())
+			conditions.MarkFalse(fwScope.LinodeFirewall, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, "%s", err.Error())
 			r.Recorder.Event(fwScope.LinodeFirewall, corev1.EventTypeWarning, string(failureReason), err.Error())
 		}
 

controller/linodemachine_controller.go

@@ -171,7 +171,9 @@ func (r *LinodeMachineReconciler) reconcile(ctx context.Context, logger logr.Log
 		if err != nil {
 			machineScope.LinodeMachine.Status.FailureReason = util.Pointer(failureReason)
 			machineScope.LinodeMachine.Status.FailureMessage = util.Pointer(err.Error())
-			conditions.MarkFalse(machineScope.LinodeMachine, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, err.Error())
+
+			conditions.MarkFalse(machineScope.LinodeMachine, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, "%s", err.Error())
+
 			r.Recorder.Event(machineScope.LinodeMachine, corev1.EventTypeWarning, string(failureReason), err.Error())
 		}
 

controller/linodemachine_controller_helpers.go

@@ -537,6 +537,7 @@ func createDisks(ctx context.Context, logger logr.Logger, machineScope *scope.Ma
 				ConditionPreflightAdditionalDisksCreated,
 				string(cerrs.CreateMachineError),
 				clusterv1.ConditionSeverityWarning,
+				"%s",
 				err.Error(),
 			)
 			return err
@@ -561,7 +562,7 @@ func resizeRootDisk(ctx context.Context, logger logr.Logger, machineScope *scope
 	if err != nil {
 		logger.Error(err, "Failed to get default instance configuration")
 
-		conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResized, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, err.Error())
+		conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResized, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, "%s", err.Error())
 		return err
 	}
 
@@ -579,7 +580,7 @@ func resizeRootDisk(ctx context.Context, logger logr.Logger, machineScope *scope
 		if err != nil {
 			logger.Error(err, "Failed to get root disk for instance")
 
-			conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResizing, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, err.Error())
+			conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResizing, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, "%s", err.Error())
 
 			return err
 		}
@@ -594,7 +595,7 @@ func resizeRootDisk(ctx context.Context, logger logr.Logger, machineScope *scope
 		}
 
 		if err := machineScope.LinodeClient.ResizeInstanceDisk(ctx, linodeInstanceID, rootDiskID, diskSize); err != nil {
-			conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResizing, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, err.Error())
+			conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResizing, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, "%s", err.Error())
 			return err
 		}
 		conditions.MarkTrue(machineScope.LinodeMachine, ConditionPreflightRootDiskResizing)

controller/linodeplacementgroup_controller.go

@@ -121,7 +121,7 @@ func (r *LinodePlacementGroupReconciler) reconcile(
 			pgScope.LinodePlacementGroup.Status.FailureReason = util.Pointer(failureReason)
 			pgScope.LinodePlacementGroup.Status.FailureMessage = util.Pointer(err.Error())
 
-			conditions.MarkFalse(pgScope.LinodePlacementGroup, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, err.Error())
+			conditions.MarkFalse(pgScope.LinodePlacementGroup, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, "%s", err.Error())
 
 			r.Recorder.Event(pgScope.LinodePlacementGroup, corev1.EventTypeWarning, string(failureReason), err.Error())
 		}

controller/linodevpc_controller.go

@@ -127,7 +127,7 @@ func (r *LinodeVPCReconciler) reconcile(
 			vpcScope.LinodeVPC.Status.FailureReason = util.Pointer(failureReason)
 			vpcScope.LinodeVPC.Status.FailureMessage = util.Pointer(err.Error())
 
-			conditions.MarkFalse(vpcScope.LinodeVPC, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, err.Error())
+			conditions.MarkFalse(vpcScope.LinodeVPC, clusterv1.ReadyCondition, string(failureReason), clusterv1.ConditionSeverityError, "%s", err.Error())
 
 			r.Recorder.Event(vpcScope.LinodeVPC, corev1.EventTypeWarning, string(failureReason), err.Error())
 		}

util/reconciler/conditions.go

@@ -31,10 +31,10 @@ func HasConditionSeverity(from conditions.Getter, typ clusterv1.ConditionType, s
 }
 
 func RecordDecayingCondition(to conditions.Setter, typ clusterv1.ConditionType, reason, message string, timeout time.Duration) bool {
-	conditions.MarkFalse(to, typ, reason, clusterv1.ConditionSeverityWarning, message)
+	conditions.MarkFalse(to, typ, reason, clusterv1.ConditionSeverityWarning, "%s", message)
 
 	if HasStaleCondition(to, typ, timeout) {
-		conditions.MarkFalse(to, typ, reason, clusterv1.ConditionSeverityError, message)
+		conditions.MarkFalse(to, typ, reason, clusterv1.ConditionSeverityError, "%s", message)
 		return true
 	}