CI: Notify slack channel on releases; Add test coverage for vlans and lke types (#665)

Co-authored-by: Youjung Kim <126618609+ykim-1@users.noreply.github.com>

Author: ykim-akamai

.github/workflows/release-notify-slack.yml

@@ -0,0 +1,30 @@
+name: Notify Dev DX Channel on Release
+on:
+  release:
+    types: [published]
+  workflow_dispatch: null
+
+jobs:
+  notify:
+    if: github.repository == 'linode/linode-cli'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Notify Slack - Main Message
+        id: main_message
+        uses: slackapi/slack-github-action@v1.27.0
+        with:
+          channel-id: ${{ secrets.CLI_SLACK_CHANNEL_ID }}
+          payload: |
+            {
+              "blocks": [
+                {
+                  "type": "section",
+                  "text": {
+                    "type": "mrkdwn",
+                    "text": "*New Release Published: _linode-cli_ <${{ github.event.release.html_url }}|${{ github.event.release.tag_name }}> is now live!* :tada:"
+                  }
+                }
+              ]
+            }
+        env:
+          SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}

tests/integration/linodes/test_power_status.py

@@ -26,6 +26,15 @@ def create_linode_in_running_state(linode_cloud_firewall):
     delete_target_id("linodes", linode_id)
 
 
+@pytest.fixture
+def create_linode_in_running_state_for_reboot(linode_cloud_firewall):
+    linode_id = create_linode_and_wait(firewall_id=linode_cloud_firewall)
+
+    yield linode_id
+
+    delete_target_id("linodes", linode_id)
+
+
 @pytest.mark.smoke
 def test_create_linode_and_boot(test_linode_id):
     linode_id = test_linode_id
@@ -36,9 +45,9 @@ def test_create_linode_and_boot(test_linode_id):
     assert result, "Linode status has not changed to running from provisioning"
 
 
-def test_reboot_linode(create_linode_in_running_state):
+def test_reboot_linode(create_linode_in_running_state_for_reboot):
     # create linode and wait until it is in "running" state
-    linode_id = create_linode_in_running_state
+    linode_id = create_linode_in_running_state_for_reboot
 
     # reboot linode from "running" status
     exec_test_command(

tests/integration/lke/test_clusters.py

@@ -2,11 +2,7 @@
 
 import pytest
 
-from tests.integration.helpers import (
-    assert_headers_in_lines,
-    exec_test_command,
-    remove_lke_clusters,
-)
+from tests.integration.helpers import assert_headers_in_lines, exec_test_command
 
 BASE_CMD = ["linode-cli", "lke"]
 
@@ -301,6 +297,24 @@ def test_version_view(test_version_id):
 
     headers = ["id"]
     assert_headers_in_lines(headers, lines)
-    # Sleep needed here for proper deletion of linodes that are related to lke cluster
-    time.sleep(5)
-    remove_lke_clusters()
+
+
+def test_list_lke_types():
+    types = (
+        exec_test_command(
+            BASE_CMD
+            + [
+                "types",
+                "--text",
+            ]
+        )
+        .stdout.decode()
+        .rstrip()
+    )
+
+    headers = ["id", "label", "price.hourly", "price.monthly", "transfer"]
+    lines = types.splitlines()
+
+    assert_headers_in_lines(headers, lines)
+    assert "LKE Standard Availability" in types
+    assert "LKE High Availability" in types

tests/integration/vlans/test_vlans.py

@@ -0,0 +1,62 @@
+from tests.integration.helpers import assert_headers_in_lines, exec_test_command
+
+BASE_CMD = ["linode-cli", "vlans"]
+
+
+def test_list_vlans():
+    types = (
+        exec_test_command(
+            BASE_CMD
+            + [
+                "ls",
+                "--text",
+            ]
+        )
+        .stdout.decode()
+        .rstrip()
+    )
+
+    headers = ["region", "label", "linodes"]
+    lines = types.splitlines()
+
+    assert_headers_in_lines(headers, lines)
+
+
+def test_list_vlans_help_menu():
+    help_menu = (
+        exec_test_command(
+            BASE_CMD
+            + [
+                "ls",
+                "--h",
+            ]
+        )
+        .stdout.decode()
+        .rstrip()
+    )
+
+    assert "linode-cli vlans ls\nList VLANs\n" in help_menu
+    assert (
+        "https://techdocs.akamai.com/linode-api/reference/get-vlans"
+        in help_menu
+    )
+
+
+def test_delete_vlans_help_menu():
+    help_menu = (
+        exec_test_command(
+            BASE_CMD
+            + [
+                "delete",
+                "--h",
+            ]
+        )
+        .stdout.decode()
+        .rstrip()
+    )
+
+    assert "linode-cli vlans delete [LABEL] [REGIONID]" in help_menu
+    assert (
+        "https://techdocs.akamai.com/linode-api/reference/delete-vlan"
+        in help_menu
+    )