Skip to content
This repository was archived by the owner on Aug 4, 2024. It is now read-only.

Commit df53dbd

Browse files
committed
Fixes an issue where computer and group target precedence may be not be processed correctly
1 parent c518345 commit df53dbd

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/Lithnet.Laps.Web/Lithnet.Laps.Web/Controllers/LapController.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ private TargetElement GetMatchingTargetOrNull(ComputerPrincipal computer)
140140
{
141141
List<TargetElement> matchingTargets = new List<TargetElement>();
142142

143-
foreach (TargetElement target in LapsConfigSection.Configuration.Targets.OfType<TargetElement>().OrderBy(t => t.Type == TargetType.Computer).ThenBy(t => t.Type == TargetType.Group))
143+
foreach (TargetElement target in LapsConfigSection.Configuration.Targets.OfType<TargetElement>())
144144
{
145145
if (target.Type == TargetType.Container)
146146
{
@@ -186,7 +186,10 @@ private TargetElement GetMatchingTargetOrNull(ComputerPrincipal computer)
186186
}
187187
}
188188

189-
return matchingTargets.OrderBy(t => t.Type == TargetType.Computer).ThenBy(t => t.Type == TargetType.Group).FirstOrDefault();
189+
return
190+
matchingTargets.FirstOrDefault(t => t.Type == TargetType.Computer) ??
191+
matchingTargets.FirstOrDefault(t => t.Type == TargetType.Group) ??
192+
matchingTargets.FirstOrDefault();
190193
}
191194

192195
private bool IsReaderAuthorized(ReaderElement reader, UserPrincipal currentUser)

0 commit comments

Comments
 (0)