Major bug in gen_mac function. preg_replace ff to fa was using an expression. Using str_replace instead

Laurent LEVIER · Laurent LEVIER · commit ad1b520d9236 · 2023-10-06T06:45:04.000Z
diff --git a/bin/gns3-optimize b/bin/gns3-optimize
@@ -561,7 +561,7 @@ function gen_uuid() {
 function gen_mac()
 {
   $md5_str=md5(random_int(0,0xffffff));
-  $md5_str=preg_replace('/ff/','/fa/',$md5_str);
+  $md5_str=str_replace('ff','fa',$md5_str);
   $mac=str_split($md5_str,2);
      
   return sprintf( '02:%s:%s:%s:%s:%s',$mac[0],$mac[1],$mac[2],$mac[3],$mac[4]);
diff --git a/bin/project-lowlevel-clone-ZFS b/bin/project-lowlevel-clone-ZFS
@@ -156,7 +156,7 @@ if (!function_exists(gen_mac))
   function gen_mac()
   {
     $md5_str=md5(random_int(0,0xffffff));
-    $md5_str=preg_replace('/ff/','/fa/',$md5_str);
+    $md5_str=str_replace('ff','fa',$md5_str);
     $mac=str_split($md5_str,2);
        
     return sprintf( '02:%s:%s:%s:%s:%s',$mac[0],$mac[1],$mac[2],$mac[3],$mac[4]);
diff --git a/bin/project-lowlevel-reset b/bin/project-lowlevel-reset
@@ -46,7 +46,7 @@ if (!function_exists('report'))
 function gen_mac()
 {
   $md5_str=md5(random_int(0,0xffffff));
-  $md5_str=preg_replace('/ff/','/fa/',$md5_str);
+  $md5_str=str_replace('ff','fa',$md5_str);
   $mac=str_split($md5_str,2);
    
   return sprintf( '02:%s:%s:%s:%s:%s',$mac[0],$mac[1],$mac[2],$mac[3],$mac[4]);

Original file line number	Diff line number	Diff line change
`@@ -561,7 +561,7 @@ function gen_uuid() {`
`561`	`561`	`function gen_mac()`
`562`	`562`	`{`
`563`	`563`	`$md5_str=md5(random_int(0,0xffffff));`
`564`		`- $md5_str=preg_replace('/ff/','/fa/',$md5_str);`
	`564`	`+ $md5_str=str_replace('ff','fa',$md5_str);`
`565`	`565`	`$mac=str_split($md5_str,2);`
`566`	`566`
`567`	`567`	`return sprintf( '02:%s:%s:%s:%s:%s',$mac[0],$mac[1],$mac[2],$mac[3],$mac[4]);`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ if (!function_exists(gen_mac))`
`156`	`156`	`function gen_mac()`
`157`	`157`	`{`
`158`	`158`	`$md5_str=md5(random_int(0,0xffffff));`
`159`		`- $md5_str=preg_replace('/ff/','/fa/',$md5_str);`
	`159`	`+ $md5_str=str_replace('ff','fa',$md5_str);`
`160`	`160`	`$mac=str_split($md5_str,2);`
`161`	`161`
`162`	`162`	`return sprintf( '02:%s:%s:%s:%s:%s',$mac[0],$mac[1],$mac[2],$mac[3],$mac[4]);`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ if (!function_exists('report'))`
`46`	`46`	`function gen_mac()`
`47`	`47`	`{`
`48`	`48`	`$md5_str=md5(random_int(0,0xffffff));`
`49`		`- $md5_str=preg_replace('/ff/','/fa/',$md5_str);`
	`49`	`+ $md5_str=str_replace('ff','fa',$md5_str);`
`50`	`50`	`$mac=str_split($md5_str,2);`
`51`	`51`
`52`	`52`	`return sprintf( '02:%s:%s:%s:%s:%s',$mac[0],$mac[1],$mac[2],$mac[3],$mac[4]);`