[iOS & Android] Calling `stop` never ends when not recording

[ddikman]

Package version
6.1.0

Environment

• Android Huawei P9,
• iPhone 8p, iOS 16.7.11

Describe the bug

On upgrading to v6.1.0 our AudioRecorder ended up deadlocking on using the AudioRecorder.

I wonder if it may be related to the introduction of the semaphores.
8d051b5#diff-583fabaf2e98a9c369810a4305a95bf57d73cd868b9eeb42117dc85648532dc7R27-R30

I found that we are calling a recorder.stop before it is actually recording and it seems this never finishes/exists.

To Reproduce

1. Instantiate the AudioRecorder
2. Call recorder.stop()

We are using this RecordConfig:

RecordConfig(
        encoder: AudioEncoder.pcm16bits,
        numChannels: 1,
        sampleRate: 16000,
        bitRate: 64000,
        autoGain: true,
        echoCancel: true,
        streamBufferSize: 2048,
        audioInterruption: AudioInterruptionMode.none,
      );

Expected behavior

The stop method either throws or finishes without error if not recording.

Workaround

I check the isRecording before calling stop and it works.

[llfbandit]

Thanks for the report.
This commit should fix the issue. Feedback welcome before release!

[llfbandit]

The commits are bad, reverting. I read again the OP with your edit. It is much clearer now.

[ddikman]

Sorry, I forgot to update the title after I edited post more troubleshooting. That was a really quick fix! It works in the quick tests I've done now on these same devices, without my workaround (in other words the original code that failed).