Skip to content

Commit 91a0244

Browse files
[CIR][NFC] Change insert/extractOp index type
1 parent 34c12ae commit 91a0244

File tree

1 file changed

+4
-26
lines changed

1 file changed

+4
-26
lines changed

clang/include/clang/CIR/Dialect/IR/CIROps.td

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3010,31 +3010,22 @@ def CIR_ExtractMemberOp : CIR_Op<"extract_member", [Pure]> {
30103010
```
30113011
}];
30123012

3013-
let arguments = (ins CIRRecordType:$record, IndexAttr:$index_attr);
3013+
let arguments = (ins CIRRecordType:$record, I64Attr:$index);
30143014
let results = (outs CIR_AnyType:$result);
30153015

30163016
let assemblyFormat = [{
3017-
$record `[` $index_attr `]` attr-dict
3017+
$record `[` $index `]` attr-dict
30183018
`:` qualified(type($record)) `->` qualified(type($result))
30193019
}];
30203020

30213021
let builders = [
3022-
OpBuilder<(ins "mlir::Type":$type, "mlir::Value":$record, "uint64_t":$index), [{
3023-
mlir::APInt fieldIdx(64, index);
3024-
build($_builder, $_state, type, record, fieldIdx);
3025-
}]>,
30263022
OpBuilder<(ins "mlir::Value":$record, "uint64_t":$index), [{
30273023
auto recordTy = mlir::cast<cir::RecordType>(record.getType());
30283024
mlir::Type memberTy = recordTy.getMembers()[index];
30293025
build($_builder, $_state, memberTy, record, index);
30303026
}]>
30313027
];
30323028

3033-
let extraClassDeclaration = [{
3034-
/// Get the index of the record member being accessed.
3035-
uint64_t getIndex() { return getIndexAttr().getZExtValue(); }
3036-
}];
3037-
30383029
let hasVerifier = 1;
30393030
}
30403031

@@ -3075,25 +3066,12 @@ def CIR_InsertMemberOp : CIR_Op<"insert_member", [
30753066
```
30763067
}];
30773068

3078-
let arguments = (ins CIRRecordType:$record, IndexAttr:$index_attr,
3069+
let arguments = (ins CIRRecordType:$record, I64Attr:$index,
30793070
CIR_AnyType:$value);
30803071
let results = (outs CIRRecordType:$result);
30813072

3082-
let builders = [
3083-
OpBuilder<(ins "mlir::Value":$record, "uint64_t":$index,
3084-
"mlir::Value":$value), [{
3085-
mlir::APInt fieldIdx(64, index);
3086-
build($_builder, $_state, record, fieldIdx, value);
3087-
}]>
3088-
];
3089-
3090-
let extraClassDeclaration = [{
3091-
/// Get the index of the record member being accessed.
3092-
uint64_t getIndex() { return getIndexAttr().getZExtValue(); }
3093-
}];
3094-
30953073
let assemblyFormat = [{
3096-
$record `[` $index_attr `]` `,` $value attr-dict
3074+
$record `[` $index `]` `,` $value attr-dict
30973075
`:` qualified(type($record)) `,` qualified(type($value))
30983076
}];
30993077

0 commit comments

Comments
 (0)