Fix OP permission fallback

- Uses ServerPlayerEntity specific getCommandSource method.
- Throws an appropriate error if the permission api is invoked by a non
server side entity

Author: DrexHD

build.gradle

@@ -9,10 +9,10 @@ repositories {
     maven { url 'https://maven.fabricmc.net/' }
 }
 
-def minecraftVersion = '1.21.2'
-def yarnBuild = 1
+def minecraftVersion = '1.21.3'
+def yarnBuild = 2
 def loaderVersion = '0.16.7'
-def fabricApiVersion = '0.106.1+1.21.2'
+def fabricApiVersion = '0.106.1+1.21.3'
 
 group = 'me.lucko'
 version = '0.3.3-SNAPSHOT'

src/main/java/me/lucko/fabric/api/permissions/v0/Options.java

@@ -26,11 +26,10 @@
 package me.lucko.fabric.api.permissions.v0;
 
 import com.mojang.authlib.GameProfile;
+import me.lucko.fabric.impl.permissions.v0.Util;
 import net.minecraft.command.CommandSource;
 import net.minecraft.entity.Entity;
-import net.minecraft.server.world.ServerWorld;
 
-import net.minecraft.world.World;
 import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.NotNull;
 
@@ -138,8 +137,7 @@ static <T> T get(@NotNull CommandSource source, @NotNull String key, T defaultVa
      */
     static @NotNull Optional<String> get(@NotNull Entity entity, @NotNull String key) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return get(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), key);
+        return get(Util.getCommandSource(entity), key);
     }
 
     /**
@@ -154,8 +152,7 @@ static <T> T get(@NotNull CommandSource source, @NotNull String key, T defaultVa
     @Contract("_, _, !null -> !null")
     static String get(@NotNull Entity entity, @NotNull String key, String defaultValue) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return get(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), key, defaultValue);
+        return get(Util.getCommandSource(entity), key, defaultValue);
     }
 
     /**
@@ -180,8 +177,7 @@ static String get(@NotNull Entity entity, @NotNull String key, String defaultVal
      */
     static <T> @NotNull Optional<T> get(@NotNull Entity entity, @NotNull String key, @NotNull Function<String, ? extends T> valueTransformer) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return get(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), key, valueTransformer);
+        return get(Util.getCommandSource(entity), key, valueTransformer);
     }
 
     /**
@@ -209,8 +205,7 @@ static String get(@NotNull Entity entity, @NotNull String key, String defaultVal
     @Contract("_, _, !null, _ -> !null")
     static <T> T get(@NotNull Entity entity, @NotNull String key, T defaultValue, @NotNull Function<String, ? extends T> valueTransformer) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return get(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), key, defaultValue, valueTransformer);
+        return get(Util.getCommandSource(entity), key, defaultValue, valueTransformer);
     }
 
     /**

src/main/java/me/lucko/fabric/api/permissions/v0/Permissions.java

@@ -26,14 +26,13 @@
 package me.lucko.fabric.api.permissions.v0;
 
 import com.mojang.authlib.GameProfile;
+import me.lucko.fabric.impl.permissions.v0.Util;
 import net.fabricmc.fabric.api.util.TriState;
 import net.minecraft.command.CommandSource;
 import net.minecraft.entity.Entity;
 import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.command.ServerCommandSource;
-import net.minecraft.server.world.ServerWorld;
 
-import net.minecraft.world.World;
 import org.jetbrains.annotations.NotNull;
 
 import java.util.Objects;
@@ -146,8 +145,7 @@ static boolean check(@NotNull CommandSource source, @NotNull String permission)
      */
     static @NotNull TriState getPermissionValue(@NotNull Entity entity, @NotNull String permission) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return getPermissionValue(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), permission);
+        return getPermissionValue(Util.getCommandSource(entity), permission);
     }
 
     /**
@@ -161,8 +159,7 @@ static boolean check(@NotNull CommandSource source, @NotNull String permission)
      */
     static boolean check(@NotNull Entity entity, @NotNull String permission, boolean defaultValue) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return check(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), permission, defaultValue);
+        return check(Util.getCommandSource(entity), permission, defaultValue);
     }
 
     /**
@@ -176,8 +173,7 @@ static boolean check(@NotNull Entity entity, @NotNull String permission, boolean
      */
     static boolean check(@NotNull Entity entity, @NotNull String permission, int defaultRequiredLevel) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return check(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), permission, defaultRequiredLevel);
+        return check(Util.getCommandSource(entity), permission, defaultRequiredLevel);
     }
 
     /**
@@ -190,8 +186,7 @@ static boolean check(@NotNull Entity entity, @NotNull String permission, int def
      */
     static boolean check(@NotNull Entity entity, @NotNull String permission) {
         Objects.requireNonNull(entity, "entity");
-        World world = entity.getWorld();
-        return check(entity.getCommandSource(world instanceof ServerWorld ? (ServerWorld) world : null), permission);
+        return check(Util.getCommandSource(entity), permission);
     }
 
     /**

src/main/java/me/lucko/fabric/impl/permissions/v0/Util.java

@@ -0,0 +1,23 @@
+package me.lucko.fabric.impl.permissions.v0;
+
+import net.minecraft.entity.Entity;
+import net.minecraft.server.command.ServerCommandSource;
+import net.minecraft.server.network.ServerPlayerEntity;
+import net.minecraft.server.world.ServerWorld;
+import net.minecraft.world.World;
+
+public class Util {
+
+    public static ServerCommandSource getCommandSource(Entity entity) {
+        if (entity instanceof ServerPlayerEntity) {
+            return ((ServerPlayerEntity) entity).getCommandSource();
+        }
+        World world = entity.getWorld();
+        if (world instanceof ServerWorld) {
+            return entity.getCommandSource((ServerWorld) world);
+        } else {
+            throw new IllegalStateException("Entity " + entity + " is not a server entity");
+        }
+    }
+
+}