Skip to content

Commit f2803a5

Browse files
authored
Merge pull request #325 from machawk1/issue-324
Fix dropdown visibility on sites that have a elements that match
2 parents 28dce26 + bba6f0e commit f2803a5

File tree

3 files changed

+18
-24
lines changed

3 files changed

+18
-24
lines changed

mink-plugin/content.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ function displayUIBasedOnContext () {
151151
case 2: link header, no datetime
152152
case 3: link header, datetime
153153
*/
154-
console.warn(headers)
154+
log(headers)
155155
for (let headerI = 0; headerI < headers.length; headerI++) {
156156
// First line: previously deleting attribute (link header) leaves null
157157
if (headers[headerI] == null) { continue }

mink-plugin/js/displayMinkUI.js

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,25 +38,26 @@ function appendHTMLToShadowDOM () {
3838
createShadowDOM(setupDrilldownInteractions)
3939
}
4040
let mCount = mementos.length
41+
const minkuiRoot = document.querySelector('#minkuiX')
4142

4243
if (items.timemaps && items.timemaps[document.URL] && items.timemaps[document.URL].mementos && items.timemaps[document.URL].datetime) {
4344
mCount = items.timemaps[document.URL].mementos.length
4445

4546
// Hide initially irrelevant UI items
46-
const selectors_to_hide = ['.dropdown', '#drildownBox', '#steps', '#title_dropdown', '#archiveNow']
47-
selectors_to_hide.forEach(selector => {
48-
document.querySelector(selector).classList.add('hidden')
47+
const selectorsToHide = ['.dropdown', '#drildownBox', '#steps', '#title_dropdown', '#archiveNow']
48+
selectorsToHide.forEach(selector => {
49+
minkuiRoot.querySelector(selector).classList.add('hidden')
4950
})
50-
51-
document.querySelector('#viewingMementoInterface').classList.remove('hidden')
5251

53-
document.querySelector('#mementosAvailable').innerHTML =
52+
minkuiRoot.querySelector('#viewingMementoInterface').classList.remove('hidden')
53+
54+
minkuiRoot.querySelector('#mementosAvailable').innerHTML =
5455
`Viewing memento at ${(new Date(items.timemaps[document.URL].datetime))}`
5556

56-
const firstButton = document.querySelector('#memento_first')
57-
const lastButton = document.querySelector('#memento_last')
58-
const prevButton = document.querySelector('#memento_prev')
59-
const nextButton = document.querySelector('#memento_next')
57+
const firstButton = minkuiRoot.querySelector('#memento_first')
58+
const lastButton = minkuiRoot.querySelector('#memento_last')
59+
const prevButton = minkuiRoot.querySelector('#memento_prev')
60+
const nextButton = minkuiRoot.querySelector('#memento_next')
6061

6162
items.timemaps[document.URL].mementos.forEach(function (mem) {
6263
let targetButton
@@ -85,9 +86,8 @@ function appendHTMLToShadowDOM () {
8586

8687
cb = createShadowDOM
8788
} else if (mCount > MAX_MEMENTOS_IN_DROPDOWN) {
88-
document.querySelector('.dropdown').classList.add('hidden')
89-
// document.querySelectorAll('#steps .action').classList.remove('active')
90-
document.querySelector('#title_drilldown').classList.add('active')
89+
minkuiRoot.querySelector('#minkuiX .dropdown').classList.add('hidden')
90+
minkuiRoot.querySelector('#minkuiX #title_drilldown').classList.add('active')
9191
buildDropDown([])
9292

9393
let cleanedURIR = document.URL
@@ -102,18 +102,17 @@ function appendHTMLToShadowDOM () {
102102
} else {
103103
buildDropDown(mementos)
104104
buildDrilldownYear(mementos)
105-
document.querySelector('#drilldownBox').classList.add('hidden')
106-
// $('#steps .action').removeClass('active')
107-
document.querySelector('#title_dropdown').classList.add('active')
105+
minkuiRoot.querySelector('#drilldownBox').classList.add('hidden')
106+
minkuiRoot.querySelector('#title_dropdown').classList.add('active')
108107
}
109108

110109
// Append CSS1
111110
let mementoPlurality = 'mementos'
112-
document.querySelector('#mementosAvailable span#mementoCount').innerHTML = mCount.toLocaleString()
111+
minkuiRoot.querySelector('#mementosAvailable span#mementoCount').innerHTML = mCount.toLocaleString()
113112
if (mCount === 1) {
114113
mementoPlurality = 'memento'
115114
}
116-
document.querySelector('#mementosAvailable span#mementoPlurality').innerHTML = mementoPlurality
115+
minkuiRoot.querySelector('#mementosAvailable span#mementoPlurality').innerHTML = mementoPlurality
117116

118117
// Append CSS2
119118
appendCSSToShadowDOM(cb)

mink-plugin/popup.html

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)